Skip to content

feat(TransactionRegister): prevent duplicate registration and stabilize CI #6447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: release_v4.8.1
Choose a base branch
from
Open

feat(TransactionRegister): prevent duplicate registration and stabilize CI #6447

wants to merge 1 commit into from

Conversation

halibobo1205
Copy link
Contributor

@halibobo1205 halibobo1205 commented Sep 10, 2025 •
edited
Loading

What does this PR do?

  • Add a registration status check to prevent duplicate initialization during CI test runs.
  • Throw TronError on actuator instantiation failures to improve error visibility and debugging.
  • Narrow package scanning from "org.tron" to "org.tron.core.actuator" to reduce reflection overhead and speed up registration.
  • Remove JVM args for CI test to avoid JDK8 G1 GC bugs and Evacuation Pause failures.
  • Optimize console output to prevent test OOM
  • Adjust memory and parallelism settings
  • exclude dnsjava InetAddressResolverProvider

Why are these changes required?
Optimize TransactionRegister to prevent duplicate CI registrations.

first init

Before: Reflections took 375 ms to scan 11 urls, producing 525 keys and 3121 values
After:  Reflections took 188 ms to scan 3 urls, producing 4 keys and 78 values

repeat init

Before: Reflections took 165 ms to scan 11 urls, producing 525 keys and 3121 values
After:  Reflections took 24 ms to scan 3 urls, producing 4 keys and 78 values

This PR has been tested by:

  • Unit Tests
  • Manual Testing

Follow up

Extra details

@halibobo1205 halibobo1205 force-pushed the feat/register_actuator_opt branch 3 times, most recently from d8f43fb to 5a9d816 Compare September 11, 2025 09:39
@halibobo1205 halibobo1205 changed the title refactor(TransactionRegister): enhance actuator registration feat(TransactionRegister): prevent duplicate registration and stabilize CI Sep 11, 2025
@halibobo1205 halibobo1205 force-pushed the feat/register_actuator_opt branch 2 times, most recently from 9092506 to ad89386 Compare September 28, 2025 07:06
@halibobo1205
feat(TransactionRegister): prevent duplicate registration and stabili…
0fbdf52 
…ze CI

Changes:
- Add a registration status check to prevent duplicate initialization during CI test runs.
- Throw TronError on actuator instantiation failures to improve error visibility and debugging.
- Narrow package scanning from "org.tron" to "org.tron.core.actuator" to reduce reflection overhead and speed up registration.
- Remove JVM args for CI test to avoid JDK8 G1 GC bugs and Evacuation Pause failures.
- Optimize console output to prevent test OOM
- Adjust memory and parallelism settings
- exclude dnsjava InetAddressResolverProvider
@halibobo1205 halibobo1205 force-pushed the feat/register_actuator_opt branch from ad89386 to 0fbdf52 Compare September 30, 2025 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@halibobo1205