[GLUON] Docstrings for public functions #7323
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterbell10
reviewed
Jun 26, 2025
Comment on lines
201
to
206
| Args: | ||
| handle (ir.Value): The IR value representing the allocation handle. | ||
| element_ty (dtype): The data type of each element. | ||
| shape (List[int]): The dimensions of the descriptor. | ||
| layout (SharedLayout): The layout of the shared memory. | ||
| alloc_shape (List[int]): The actual allocation shape. |
There was a problem hiding this comment.
Since the __init__ is not part of the public API, we probably don't want the arguments documented here.
python/triton/experimental/gluon/language/nvidia/ampere/async_copy.py
Outdated
Show resolved
Hide resolved
python/triton/experimental/gluon/language/nvidia/ampere/async_copy.py
Outdated
Show resolved
Hide resolved
python/triton/experimental/gluon/language/nvidia/blackwell/__init__.py
Outdated
Show resolved
Hide resolved
python/triton/experimental/gluon/language/nvidia/blackwell/tma.py
Outdated
Show resolved
Hide resolved
python/triton/experimental/gluon/language/nvidia/blackwell/tma.py
Outdated
Show resolved
Hide resolved
python/triton/experimental/gluon/language/nvidia/hopper/__init__.py
Outdated
Show resolved
Hide resolved
python/triton/experimental/gluon/language/nvidia/hopper/__init__.py
Outdated
Show resolved
Hide resolved
python/triton/experimental/gluon/language/nvidia/hopper/__init__.py
Outdated
Show resolved
Hide resolved
|
Thanks for taking the time @peterbell10 ! |
peterbell10
reviewed
Jun 27, 2025
python/triton/experimental/gluon/language/nvidia/hopper/__init__.py
Outdated
Show resolved
Hide resolved
peterbell10
approved these changes
Jun 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding documentation for public gluon API. Generated by codex, with proof-reading and editing some of the issues by me. Formatting differs from triton docstrings, (using Google style rather than reST), but subjectively this seems more readable. Changing to reST formatting should be relatively easy if people have strong opinions about this.