feat: Allow per-model metric configuration #405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 29, 2024
GuanLuo
reviewed
Oct 29, 2024
rmccorm4
reviewed
Nov 1, 2024
rmccorm4
reviewed
Nov 1, 2024
GuanLuo
reviewed
Nov 4, 2024
Co-authored-by: GuanLuo <[email protected]>
rmccorm4
reviewed
Nov 5, 2024
rmccorm4
previously approved these changes
Nov 5, 2024
…into yinggeh-DLIS-7457-per-model-metric-config
GuanLuo
previously approved these changes
Nov 5, 2024
rmccorm4
reviewed
Nov 6, 2024
rmccorm4
approved these changes
Nov 6, 2024
indrajit96
added a commit
that referenced
this pull request
Dec 9, 2024
…)" This reverts commit 1d18c2b.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do?
Tests new model_metrics message in pbtxt. Add example to override histogram buckets per-family.
Checklist
<commit_type>: <Title>Commit Type:
Check the conventional commit type
box here and add the label to the github PR.
Related PRs:
triton-inference-server/common#126
triton-inference-server/server#7752
Where should the reviewer start?
Test plan:
L0_metrics
20106057
Caveats:
Background
Default histogram buckets does not satisfy all use cases.