Skip to content

Conversation

@wendigo
Copy link
Contributor

@wendigo wendigo commented Oct 16, 2025

Description

Additional context and related issues

Release notes

( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

## Section
* Fix some things. ({issue}`issuenumber`)

Summary by Sourcery

Upgrade Jetty to version 12.1.3 RC, add its repository, and enable HTTP compression by default.

Enhancements:

  • Enable HTTP compression by default in the server configuration.

Build:

  • Bump Jetty dependency to 12.1.3 RC.
  • Add a custom Apache repository for Jetty 12.1.3 RC artifacts.

@cla-bot cla-bot bot added the cla-signed label Oct 16, 2025
@sourcery-ai
Copy link

sourcery-ai bot commented Oct 16, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Bumps Jetty to version 12.1.3 RC by introducing a new version property and temporary repository, and restores HTTP compression in the server configuration.

Class diagram for updated HttpServerConfig usage

classDiagram
    class HttpServerConfig {
        +setHttp2MaxConcurrentStreams(int)
        +setCompressionEnabled(boolean)
    }
    ServerMainModule --> HttpServerConfig : configures
    class ServerMainModule {
        +setup(Binder)
    }
Loading

File-Level Changes

Change Details Files
Upgrade Jetty to 12.1.3 RC and add repository for RC artifacts
  • Add dep.jetty.version property set to 12.1.3
  • Define 'apache-releases' repository pointing to the RC URL
pom.xml
Re-enable HTTP compression in server configuration
  • Change default compressionEnabled from false to true in HttpServerConfig binding
core/trino-main/src/main/java/io/trino/server/ServerMainModule.java

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes - here's some feedback:

  • Avoid committing a custom RC repository URL—depend on Jetty releases from Maven Central or Trino’s snapshot repositories instead.
  • Since compression was previously disabled due to a Jetty bug, please add a code comment or link to the release notes explaining why it’s now safe to re-enable HTTP compression.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Avoid committing a custom RC repository URL—depend on Jetty releases from Maven Central or Trino’s snapshot repositories instead.
- Since compression was previously disabled due to a Jetty bug, please add a code comment or link to the release notes explaining why it’s now safe to re-enable HTTP compression.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@starburstdata-automation
Copy link

starburstdata-automation commented Oct 16, 2025

Started benchmark workflow for this PR with test type = iceberg/sf1000_parquet_part.

Building Trino finished with status: success
Benchmark finished with status: success
Comparing results to the static baseline values, follow above workflow link for more details/logs.
Status message: NO Regression found.
Benchmark Comparison to the closest run from Master: Report

@starburstdata-automation
Copy link

starburstdata-automation commented Oct 16, 2025

Started benchmark workflow for this PR with test type = iceberg/sf1000_parquet_unpart.

Building Trino finished with status: success
Benchmark finished with status: success
Comparing results to the static baseline values, follow above workflow link for more details/logs.
Status message: NO Regression found.
Benchmark Comparison to the closest run from Master: Report

@starburstdata-automation
Copy link

starburstdata-automation commented Oct 16, 2025

Started benchmark workflow for this PR with test type = iceberg/sf1000_parquet_part.

Building Trino finished with status: success
Benchmark finished with status: success
Comparing results to the static baseline values, follow above workflow link for more details/logs.
Status message: NO Regression found.
Benchmark Comparison to the closest run from Master: Report

@starburstdata-automation
Copy link

starburstdata-automation commented Oct 16, 2025

Started benchmark workflow for this PR with test type = iceberg/sf1000_parquet_unpart.

Building Trino finished with status: success
Benchmark finished with status: success
Comparing results to the static baseline values, follow above workflow link for more details/logs.
Status message: NO Regression found.
Benchmark Comparison to the closest run from Master: Report

@wendigo wendigo force-pushed the serafin/test-jetty-12-1-3-snapshot branch from 93030a9 to fb5c598 Compare October 17, 2025 08:30
@starburstdata-automation
Copy link

starburstdata-automation commented Oct 17, 2025

Started benchmark workflow for this PR with test type = iceberg/sf1000_parquet_unpart.

Building Trino finished with status: success
Benchmark finished with status: success
Comparing results to the static baseline values, follow above workflow link for more details/logs.
Status message: NO Regression found.
Benchmark Comparison to the closest run from Master: Report

@wendigo wendigo closed this Oct 23, 2025
@wendigo wendigo deleted the serafin/test-jetty-12-1-3-snapshot branch October 23, 2025 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants