-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Test Jetty 12.1.3 RC #26985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test Jetty 12.1.3 RC #26985
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideBumps Jetty to version 12.1.3 RC by introducing a new version property and temporary repository, and restores HTTP compression in the server configuration. Class diagram for updated HttpServerConfig usageclassDiagram
class HttpServerConfig {
+setHttp2MaxConcurrentStreams(int)
+setCompressionEnabled(boolean)
}
ServerMainModule --> HttpServerConfig : configures
class ServerMainModule {
+setup(Binder)
}
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there - I've reviewed your changes - here's some feedback:
- Avoid committing a custom RC repository URL—depend on Jetty releases from Maven Central or Trino’s snapshot repositories instead.
- Since compression was previously disabled due to a Jetty bug, please add a code comment or link to the release notes explaining why it’s now safe to re-enable HTTP compression.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Avoid committing a custom RC repository URL—depend on Jetty releases from Maven Central or Trino’s snapshot repositories instead.
- Since compression was previously disabled due to a Jetty bug, please add a code comment or link to the release notes explaining why it’s now safe to re-enable HTTP compression.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
Started benchmark workflow for this PR with test type =
|
|
Started benchmark workflow for this PR with test type =
|
|
Started benchmark workflow for this PR with test type =
|
|
Started benchmark workflow for this PR with test type =
|
93030a9 to
fb5c598
Compare
|
Started benchmark workflow for this PR with test type =
|
Description
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:
Summary by Sourcery
Upgrade Jetty to version 12.1.3 RC, add its repository, and enable HTTP compression by default.
Enhancements:
Build: