Skip to content

Conversation

@pettyjamesm
Copy link
Member

@pettyjamesm pettyjamesm commented May 13, 2025

Description

Fixes #25780

Release notes

( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text:

## Iceberg connector
* Fix expire_snapshots functionality when using an Iceberg REST catalog and S3 compatible storage ({issue}`25782`)

@cla-bot cla-bot bot added the cla-signed label May 13, 2025
@pettyjamesm pettyjamesm marked this pull request as ready for review May 13, 2025 14:39
// remove me once all of the S3-compatible storage support strong integrity checks
@SuppressWarnings("deprecation")
static AwsRequestOverrideConfiguration disableStrongIntegrityChecksums()
static AwsRequestOverrideConfiguration.Builder disableStrongIntegrityChecksums(AwsRequestOverrideConfiguration.Builder builder)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We added LegacyMd5Plugin in #25711. Why do we still need this method?
cc: @wendigo

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#25791 this should help I think

Copy link
Member

@ebyhr ebyhr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a test?

@pettyjamesm
Copy link
Member Author

Closing in favor of #25791

@pettyjamesm pettyjamesm deleted the fix-iceberg-s3-delete-override branch May 14, 2025 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

Trino forgets vended-credentials in S3FileSystem::deleteObjects

3 participants