New HsqlDB connector #23061
New HsqlDB connector #23061
Conversation
prrvchr
force-pushed
the
hsqldb
branch
4 times, most recently
from
b50a6ca to
a559036
Compare
prrvchr
force-pushed
the
hsqldb
branch
4 times, most recently
from
e02c7ae to
b7fddc2
Compare
...uncher/src/main/java/io/trino/tests/product/launcher/env/environment/EnvMultinodeHsqldb.java
Outdated
Show resolved
Hide resolved
|
Well I have to admit that I only have 4GB of memory on my laptop and that I am unable to launch the tests locally (it freezes my terminal) and that therefore I am obliged to push in order to obtain a result... |
prrvchr
force-pushed
the
hsqldb
branch
3 times, most recently
from
35a052b to
7051d03
Compare
There was a problem hiding this comment.
I would recommend removing timestamp types from the initial PR as most developers introduce a bug during the implementation.
There was a problem hiding this comment.
Ok, TIMESTAMP and TIMESTAMP_WITH_TIMEZONE were removed from this initial PR (ie: see file HsqlDbClient.java)
There was a problem hiding this comment.
Worth leaving a code comment why specifying this property.
There was a problem hiding this comment.
Remove a redundant base class. All code should go to TestHsqlDbConnectorTest.
There was a problem hiding this comment.
Please sort alphabetically. Also, remove redundant conditions holding the same value in the base class.
There was a problem hiding this comment.
Remove redundant System.out.println. Same for others.
There was a problem hiding this comment.
https://trino.io/docs/current/develop/tests.html
Test classes should be defined as package-private and final.
Same for others.
There was a problem hiding this comment.
https://trino.io/docs/current/develop/tests.html
Test methods should be defined as package-private.
Same for others.
There was a problem hiding this comment.
No need to add a smoke test unless you run with the different HSQLDB version from TestHsqlDbConnectorTest.
|
This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua |
|
Closing this pull request, as it has been stale for six weeks. Feel free to re-open at any time. |
|
I'm almost done with whatever's been stopping me from continuing here. |
|
This pull request has gone a while without any activity. Ask for help on #core-dev on Trino slack. |
|
Closing this pull request, as it has been stale for six weeks. Feel free to re-open at any time. |
|
This pull request has gone a while without any activity. Ask for help on #core-dev on Trino slack. |
|
Closing this pull request, as it has been stale for six weeks. Feel free to re-open at any time. |
|
This PR has been closed and a new attempt is available here: #27227 |
5 participants
Description
Add new HsqlDB connector
Additional context and related issues
I would like to add some pure JDBC functions to Trino in order to be able to provide better integration with LibreOffice Base.
This new connector is a good way to achieve this...
The ultimate goal is to offer LibreOffice Base the possibility via Trino to consolidate or even edit data coming from different DBMS in a very easy way.
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text: