Avoid ignoring files visible in Hive #16932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findinpath
commented
Apr 7, 2023
| // Rename the table files to Hive hidden files (prefixed by `.` or `_` characters) | ||
| for (String filename : hdfsClient.listDirectory(tableLocation)) { | ||
| try (ByteArrayOutputStream bos = new ByteArrayOutputStream()) { | ||
| hdfsClient.loadFile(tableLocation + "/" + filename, bos); |
There was a problem hiding this comment.
The renaming of the files could be done much easier with trinodb/tempto#95
pettyjamesm
approved these changes
Apr 7, 2023
There was a problem hiding this comment.
LGTM, thanks for picking this up to get it over the finish line @findinpath
findinpath
force-pushed
the
findinpath/hive_off_by_1
branch
from
580acc3 to
5b3273b
Compare
ebyhr
approved these changes
Apr 10, 2023
testing/trino-product-tests/src/main/java/io/trino/tests/product/hive/TestHiveHiddenFiles.java
Outdated
Show resolved
Hide resolved
testing/trino-product-tests/src/main/java/io/trino/tests/product/hive/TestHiveHiddenFiles.java
Outdated
Show resolved
Hide resolved
testing/trino-product-tests/src/main/java/io/trino/tests/product/hive/TestHiveHiddenFiles.java
Outdated
Show resolved
Hide resolved
testing/trino-product-tests/src/main/java/io/trino/tests/product/hive/TestHiveHiddenFiles.java
Outdated
Show resolved
Hide resolved
testing/trino-product-tests/src/main/java/io/trino/tests/product/hive/TestHiveHiddenFiles.java
Outdated
Show resolved
Hide resolved
findinpath
force-pushed
the
findinpath/hive_off_by_1
branch
from
5b3273b to
45a365d
Compare
Ignore in Hive only the files which have their names or the names of their ancestor beginning with `.` or `_` characters.
findinpath
force-pushed
the
findinpath/hive_off_by_1
branch
from
45a365d to
05657f7
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ignore in Hive only the files which have their names or the names of
their ancestor beginning with
.or_characters.As agreed on Slack with @dprophet , this PR is a mere spin-off from #16387 used just to illustrate the creation of product tests corresponding for the initial PR.
@dprophet feel free to use the product tests in the original PR. No need for co-authoring.
Fixes #16386
Additional context and related issues
The newly added product tests can be executed with
Release notes
( ) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
(x) Release notes are required, with the following suggested text: