Add the toString override to build the role header string #21
Conversation
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
|
|
||
| public override string ToString() | ||
| { | ||
| return Type.ROLE.ToString()+"{"+Role+"}"; |
There was a problem hiding this comment.
This needs to work regardless of the role type. This impl only works for role type = ROLE. What about NONE and ALL?
There was a problem hiding this comment.
Silly me, Thank you!! I fixed it and tested with ROLE and NONE and ALL
There was a problem hiding this comment.
@stephen-zhao : Can you please check if the changes look okay?
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
There was a problem hiding this comment.
I noticed in the java reference impl for this class, Role is an optional string, which is inconsistent with what's here. But that can be deemed a separate issue. At least for these changes, since Role is already validated to be not null at construct-time, and is immutable, I think it's safe.
Though please sign the CLA before this can be considered for merge. Also, we will need approvals from the maintainers, as I am but a contributor.
Issue: 19
A simple fix to handle the building the ROLE trino header to set the user role assumption. Please feel free to comment/suggest better way to handle.