Establish socket connection in Ruby #218
Draft
+116
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
byroot
reviewed
Jan 31, 2025
jhawthorn
force-pushed
the
pure_ruby_socket
branch
from
04bb21c to
0c972f7
Compare
Merged
This moves the responsability for establishing the initial TCP or unix socket connection to Ruby. This allows us to lean on Ruby's implementation and configuration of DNS timeouts as well as happy eyeballs/fast fallback. In addition to improved timeouts, this should also deliver more detailed and specific error messages. Co-authored-by: Adam Hess <[email protected]> Co-authored-by: Jean Boussier <[email protected]>
jhawthorn
force-pushed
the
pure_ruby_socket
branch
from
0c972f7 to
f931366
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by @byroot's work in #139
This moves the responsibility for establishing the initial TCP or unix socket connection to Ruby. This allows us to lean on Ruby's implementation and configuration of DNS timeouts as well as happy eyeballs/fast fallback.
In addition to improved timeouts, this should also deliver more detailed and specific error messages.
Before
After
Doesn't seem to be a significant performance difference