Skip to content

Remove parts specific to internal implementation from the general BrickInterface #879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iakov merged 7 commits into from
May 13, 2026
Merged

Remove parts specific to internal implementation from the general BrickInterface #879

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
67b1ed5
Remove the dependency on QuickItem in BrickInterface
MinyazevR May 11, 2026
fc8cc9b
Change the qmake option for compatibility
MinyazevR May 11, 2026
26eaeb1
Remove unnecessary dependencies
MinyazevR May 11, 2026
75706da
Ignore generated files when formatting
MinyazevR May 11, 2026
8ceeeb5
Fix Clang-Tidy warnings
MinyazevR May 11, 2026
f3a2ad1
Clang-Tidy: Ignore generated_cpp
MinyazevR May 11, 2026
e370785
Switch BrickFactory to private parts
MinyazevR May 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/linter.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ jobs:
database: ${{ env.BUILD_DIR }}
verbosity: 'info'
files-changed-only: true
ignore-tidy: '^(PythonQt|mlx90640-library)$'
ignore-tidy: 'PythonQt/**|mlx90640-library/**|**/generated_cpp/**'

- name: Clang-tidy exit
if: ${{ steps.linter.outputs.checks-failed > 0 }}
Expand All @@ -113,4 +113,4 @@ jobs:
ignore-dirs: '^(PythonQt|mlx90640-library)$'
root-dir: ${{ github.workspace }}
ignore-header-deps: true
ignore-external-files: true
ignore-external-files: true
69 changes: 63 additions & 6 deletions PythonQt/mjb_rejected_classes.log
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,30 @@
************************************************************************
Not in type system
<object-type name="QArgument"/>
<object-type name="QCoreApplication::QPrivateSignal"/>
<object-type name="QEventLoop::QPrivateSignal"/>
<object-type name="QFile::QPrivateSignal"/>
<object-type name="QFileDevice::QPrivateSignal"/>
<object-type name="QGenericArgument"/>
<object-type name="QGenericReturnArgument"/>
<object-type name="QIODevice::QPrivateSignal"/>
<object-type name="QJSValue"/>
<object-type name="QMetaObject::Connection"/>
<object-type name="QMetaObject::SuperData"/>
<object-type name="QObject::QPrivateSignal"/>
<object-type name="QPointingDeviceUniqueId"/>
<object-type name="QQmlComponent"/>
<object-type name="QQmlError"/>
<object-type name="QQmlListProperty"/>
<object-type name="QQmlListReference"/>
<object-type name="QQmlParserStatus"/>
<object-type name="QQmlPropertyValueSource"/>
<object-type name="QQmlTypeInfo"/>
<object-type name="QQuickItem::QPrivateSignal"/>
<object-type name="QQuickPaintedItem::QPrivateSignal"/>
<object-type name="QQuickTransform::QPrivateSignal"/>
<object-type name="QReturnArgument"/>
<object-type name="QWidget::QPrivateSignal"/>
<object-type name="QmlTypeAndRevisionsRegistration"/>
<object-type name="trikControl::BatteryInterface::QPrivateSignal"/>
<object-type name="trikControl::BrickInterface::QPrivateSignal"/>
<object-type name="trikControl::ColorSensorInterface::QPrivateSignal"/>
Expand All @@ -22,6 +38,8 @@ Not in type system
<object-type name="trikControl::GamepadInterface::QPrivateSignal"/>
<object-type name="trikControl::GyroSensorInterface::QPrivateSignal"/>
<object-type name="trikControl::I2cDeviceInterface::QPrivateSignal"/>
<object-type name="trikControl::InternalBrickInterface::QPrivateSignal"/>
<object-type name="trikControl::InternalDisplayInterface::QPrivateSignal"/>
<object-type name="trikControl::IrCameraInterface::QPrivateSignal"/>
<object-type name="trikControl::KeysInterface::QPrivateSignal"/>
<object-type name="trikControl::LedInterface::QPrivateSignal"/>
Expand All @@ -38,30 +56,53 @@ Not in type system

************************************************************************
Generation disabled by type system
<object-type name="QAccessible"/>
<object-type name="QAccessibleActionInterface"/>
<object-type name="QAccessibleEditableTextInterface"/>
<object-type name="QAccessibleImageInterface"/>
<object-type name="QAccessibleInterface"/>
<object-type name="QAccessibleStateChangeEvent"/>
<object-type name="QAccessibleTableCellInterface"/>
<object-type name="QAccessibleTableInterface"/>
<object-type name="QAccessibleTableModelChangeEvent"/>
<object-type name="QAccessibleTextCursorEvent"/>
<object-type name="QAccessibleTextInsertEvent"/>
<object-type name="QAccessibleTextInterface"/>
<object-type name="QAccessibleTextRemoveEvent"/>
<object-type name="QAccessibleTextSelectionEvent"/>
<object-type name="QAccessibleTextUpdateEvent"/>
<object-type name="QAccessibleValueChangeEvent"/>
<object-type name="QAccessibleValueInterface"/>
<object-type name="QAlgorithmsPrivate"/>
<object-type name="QArrayData"/>
<object-type name="QArrayDataPointerRef"/>
<object-type name="QAssociativeIterable"/>
<object-type name="QAtomicInt"/>
<object-type name="QAtomicInteger"/>
<object-type name="QAtomicPointer"/>
<object-type name="QBasicAtomicInteger"/>
<object-type name="QBasicAtomicPointer"/>
<object-type name="QBrushData"/>
<object-type name="QByteArrayDataPtr"/>
<object-type name="QChar"/>
<object-type name="QCharRef"/>
<object-type name="QColor::CT"/>
<object-type name="QContiguousCache"/>
<object-type name="QContiguousCacheData"/>
<object-type name="QContiguousCacheTypedData"/>
<object-type name="QDebug"/>
<object-type name="QDebugStateSaver"/>
<object-type name="QEnableSharedFromThis"/>
<object-type name="QEventLoopLocker"/>
<object-type name="QExplicitlySharedDataPointer"/>
<object-type name="QFlag"/>
<object-type name="QFlags"/>
<object-type name="QGradient::QGradientData"/>
<object-type name="QHash"/>
<object-type name="QHashData"/>
<object-type name="QHashDummyValue"/>
<object-type name="QHashIterator"/>
<object-type name="QHashNode"/>
<object-type name="QIncompatibleFlag"/>
<object-type name="QInputMethodQueryEvent::QueryPair"/>
<object-type name="QIntegerForSize>"/>
<object-type name="QIntegerForSizeof"/>
<object-type name="QInternal"/>
Expand All @@ -75,27 +116,40 @@ Generation disabled by type system
<object-type name="QListData"/>
<object-type name="QListIterator"/>
<object-type name="QListSpecialMethods"/>
<object-type name="QMap"/>
<object-type name="QMapData"/>
<object-type name="QMapDataBase"/>
<object-type name="QMapIterator"/>
<object-type name="QMapNode"/>
<object-type name="QMapNodeBase"/>
<object-type name="QMetaTypeId"/>
<object-type name="QMetaTypeId2"/>
<object-type name="QMetaTypeIdQObject"/>
<object-type name="QMultiHash"/>
<object-type name="QMultiMap"/>
<object-type name="QMutableHashIterator"/>
<object-type name="QMutableListIterator"/>
<object-type name="QMutableMapIterator"/>
<object-type name="QMutableSetIterator"/>
<object-type name="QMutableVectorIterator"/>
<object-type name="QNoDebug"/>
<object-type name="QObjectData"/>
<object-type name="QObjectUserData"/>
<object-type name="QPalette::Data"/>
<object-type name="QPointer"/>
<object-type name="QQuickItem::ItemChangeData"/>
<object-type name="QRegion::QRegionData"/>
<object-type name="QScopedArrayPointer"/>
<object-type name="QScopedPointer"/>
<object-type name="QScopedPointerArrayDeleter"/>
<object-type name="QScopedPointerDeleter"/>
<object-type name="QScopedPointerObjectDeleteLater"/>
<object-type name="QScopedPointerPodDeleter"/>
<object-type name="QSequentialIterable"/>
<object-type name="QSet"/>
<object-type name="QSetIterator"/>
<object-type name="QSharedData"/>
<object-type name="QSharedDataPointer"/>
<object-type name="QSharedPointer"/>
<object-type name="QSizePolicy::Bits"/>
<object-type name="QStaticArrayData"/>
<object-type name="QStaticByteArrayData"/>
<object-type name="QStaticStringData"/>
Expand All @@ -104,15 +158,18 @@ Generation disabled by type system
<object-type name="QStringMatcher::Data"/>
<object-type name="QStringRef"/>
<object-type name="QStringView"/>
<object-type name="QTextStreamManipulator"/>
<object-type name="QTypeInfo"/>
<object-type name="QTypeInfoMerger"/>
<object-type name="QTypeInfoQuery"/>
<object-type name="QTypedArrayData"/>
<object-type name="QUrlTwoFlags"/>
<object-type name="QVarLengthArray"/>
<object-type name="QVariant"/>
<object-type name="QVariantComparisonHelper"/>
<object-type name="QVector::AlignmentDummy"/>
<object-type name="QVectorIterator"/>
<object-type name="QWeakPointer"/>
<object-type name="QWidgetData"/>
<object-type name="QtPrivate"/>
<object-type name="qGreater"/>
<object-type name="qLess"/>
Expand Down
5 changes: 4 additions & 1 deletion PythonQt/mjb_rejected_enums.log
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,19 +1,22 @@
************************************************************************
Not in type system
<enum-type name="QCoreApplication::enum_1"/>
<enum-type name="QMetaObject::Call"/>
<enum-type name="enum_3"/>
************************************************************************

************************************************************************
Generation disabled by type system
<enum-type name="QFont::ResolveProperties"/>
<enum-type name="QGradient::InterpolationMode"/>
<enum-type name="QMetaType::Type"/>
<enum-type name="QSysInfo::MacVersion"/>
<enum-type name="QSysInfo::WinVersion"/>
<enum-type name="QWheelEvent::enum_1"/>
<enum-type name="Qt::Initialization"/>
<enum-type name="Qt::Modifier"/>
<enum-type name="Qt::ReturnByValueConstant"/>
<enum-type name="enum_1"/>
<enum-type name="enum_2"/>
************************************************************************

************************************************************************
Expand Down
2 changes: 2 additions & 0 deletions PythonQt/mjb_rejected_fields.log
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,10 @@ Not in type system

************************************************************************
Generation disabled by type system
QEvent::d
QMetaObject::d
QObject::d_ptr
QTabletEvent::mExtra
************************************************************************

************************************************************************
Expand Down
Loading
Loading