-
-
Notifications
You must be signed in to change notification settings - Fork 831
feat(otel): Add support for storing run spans and log data in Clickhouse #2567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ericallam
wants to merge
21
commits into
main
Choose a base branch
from
feat/clickhouse-otel
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
5775d60
WIP
ericallam cbf0872
WIP clickhouse repo
ericallam 2c0b7bf
wip
ericallam 155fc5e
cleaned up what is returned from EventRepository.getSpan
ericallam 0d5eb9f
simplify getSpan and remove some unnecessary properties
ericallam 3295f35
removed a bunch of unnecessary data
ericallam eaeaa1e
use feature flags to determine the run taskEvent store
ericallam bf97d4b
more clickhouse events stuff
ericallam 5595160
implement more
ericallam bf436cd
Runs always show a trace
ericallam 8b7baf4
crashEvent isn't used anymore
ericallam d3363ab
implement ancestor overrides for trace summary
ericallam 0274eb9
implement getSpan
ericallam 97ab22b
support debug logs
ericallam 8a78d35
add support to prod v4 and v3 runs
ericallam f4ff15c
v3 task trigger works with clickhouse
ericallam 16dedd9
wip trace detail
ericallam f9dba60
Some fixes for the conflicts
ericallam f197c58
implemented both detailed trace view and events/download logs in clic…
ericallam 0f5503b
move over the remaining v3 places that used the postgresql event repo…
ericallam 5cfe68e
Add percent-based rollout of clickhouse logs
ericallam File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pass the traceId into getSpanOriginalRunId
IEventRepository.getSpanOriginalRunId
expects(storeTable, environmentId, spanId, traceId, …)
, but this call passesenvironmentId
for thetraceId
slot. That breaks ClickHouse-backed lookups (and pollutes the cache key) so the original run is never found, causing cached runs to fall back to the plain span path. Please wire the actualtraceId
through.📝 Committable suggestion
🤖 Prompt for AI Agents