Remove experimental bun support #2048
Conversation
🦋 Changeset detectedLatest commit: 988a398 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
WalkthroughThis change removes all experimental support and documentation for the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant CLI
participant ConfigValidator
User->>CLI: trigger init --runtime bun
CLI->>ConfigValidator: Validate runtime
ConfigValidator-->>CLI: Throw error ("Bun support removed, use node")
CLI-->>User: Display error and exit
Suggested reviewers
Poem
Tip ⚡️ Faster reviews with caching
Enjoy the performance boost—your workflow just got faster. ✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🔭 Outside diff range comments (1)
packages/rsc/src/build.ts (1)
4-7: 🛠️ Refactor suggestionType definition still includes removed runtime
While the implementation code has been updated to remove Bun support, the type definition for
reactDomEnvironmentstill includes"bun"as a valid option.export type RSCExtensionOptions = { resolveDir?: string; - reactDomEnvironment?: "node" | "worker" | "bun"; + reactDomEnvironment?: "node" | "worker"; };
🧹 Nitpick comments (1)
.cursor/rules/writing-tasks.mdc (1)
2-4: Ensure consistent spacing in theglobsfield
The comma-delimited patterns should have a space after each comma for readability and consistency.--- a/.cursor/rules/writing-tasks.mdc +++ b/.cursor/rules/writing-tasks.mdc @@ line 3 - globs: **/trigger/**/*.ts, **/trigger/**/*.tsx,**/trigger/**/*.js,**/trigger/**/*.jsx + globs: **/trigger/**/*.ts, **/trigger/**/*.tsx, **/trigger/**/*.js, **/trigger/**/*.jsx
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (25)
.changeset/mighty-dryers-warn.md(1 hunks).cursor/rules/writing-tasks.mdc(2 hunks)docs/config/config-file.mdx(0 hunks)docs/config/extensions/custom.mdx(1 hunks)docs/docs.json(0 hunks)docs/guides/frameworks/bun.mdx(0 hunks)docs/guides/introduction.mdx(0 hunks)docs/upgrade-to-v4.mdx(1 hunks)packages/cli-v3/src/build/plugins.ts(0 hunks)packages/cli-v3/src/commands/init.ts(1 hunks)packages/cli-v3/src/config.ts(1 hunks)packages/cli-v3/src/deploy/buildImage.ts(1 hunks)packages/cli-v3/src/executions/taskRunProcess.ts(0 hunks)packages/cli-v3/src/runtimes/bun.ts(0 hunks)packages/core/src/v3/build/runtime.ts(3 hunks)packages/core/src/v3/config.ts(1 hunks)packages/core/src/v3/schemas/build.ts(1 hunks)packages/rsc/src/build.ts(1 hunks)references/bun-catalog/.env.example(0 hunks)references/bun-catalog/.gitignore(0 hunks)references/bun-catalog/README.md(0 hunks)references/bun-catalog/package.json(0 hunks)references/bun-catalog/src/trigger/bun.ts(0 hunks)references/bun-catalog/trigger.config.ts(0 hunks)references/bun-catalog/tsconfig.json(0 hunks)
💤 Files with no reviewable changes (14)
- docs/guides/introduction.mdx
- references/bun-catalog/.gitignore
- docs/docs.json
- docs/config/config-file.mdx
- references/bun-catalog/.env.example
- packages/cli-v3/src/runtimes/bun.ts
- packages/cli-v3/src/executions/taskRunProcess.ts
- references/bun-catalog/src/trigger/bun.ts
- references/bun-catalog/tsconfig.json
- references/bun-catalog/package.json
- references/bun-catalog/README.md
- references/bun-catalog/trigger.config.ts
- packages/cli-v3/src/build/plugins.ts
- docs/guides/frameworks/bun.mdx
🧰 Additional context used
🧬 Code Graph Analysis (1)
packages/cli-v3/src/deploy/buildImage.ts (1)
packages/core/src/v3/schemas/build.ts (2)
BuildRuntime(16-16)BuildRuntime(18-18)
⏰ Context from checks skipped due to timeout of 90000ms (7)
- GitHub Check: e2e / 🧪 CLI v3 tests (windows-latest - pnpm)
- GitHub Check: e2e / 🧪 CLI v3 tests (windows-latest - npm)
- GitHub Check: e2e / 🧪 CLI v3 tests (ubuntu-latest - pnpm)
- GitHub Check: e2e / 🧪 CLI v3 tests (ubuntu-latest - npm)
- GitHub Check: units / 🧪 Unit Tests
- GitHub Check: typecheck / typecheck
- GitHub Check: Analyze (javascript-typescript)
🔇 Additional comments (15)
.cursor/rules/writing-tasks.mdc (1)
1168-1168: Approve removal of Bun runtime from the example
The example now correctly reflects that only the"node"runtime is supported, matching the PR objective to drop experimental Bun support.docs/config/extensions/custom.mdx (1)
253-253: Documentation accurately updated to reflect runtime support.The description has been correctly updated to indicate that only the
noderuntime is supported, which aligns with the PR objective of removing experimental bun support.docs/upgrade-to-v4.mdx (1)
864-866: Good addition to breaking changes documentation.Adding this "Runtime changes" section to the upgrade guide appropriately informs users about the removal of experimental bun support, which is a breaking change for anyone using it.
.changeset/mighty-dryers-warn.md (1)
1-7: Appropriate changeset for version updates.The changeset correctly identifies the affected packages and uses patch versions, which is appropriate for removing an experimental feature. The description accurately summarizes the change.
packages/core/src/v3/config.ts (1)
24-25: JSDoc formatting improvement.The JSDoc comment has been formatted with better spacing, which improves readability while maintaining the information about the default runtime.
packages/core/src/v3/schemas/build.ts (1)
16-16: Core schema updated to enforce runtime support policy.The
BuildRuntimeenum has been correctly updated to remove "bun" and replace "node-22" with "node-test", which aligns with the PR objective and ensures that configuration validation will enforce the new runtime support policy.packages/cli-v3/src/commands/init.ts (1)
70-72: Accurately updated CLI documentationThe runtime option description now correctly reflects that only Node.js is supported, aligning with the removal of experimental Bun support.
packages/rsc/src/build.ts (1)
92-92: Simplified runtime resolution logicThe condition assignment has been properly simplified to remove Bun-specific handling, aligning with the removal of Bun runtime support.
packages/cli-v3/src/config.ts (1)
332-334: Properly enforced runtime restrictionsThe configuration validation now correctly throws an error if "bun" is specified as the runtime. The error message is clear and provides useful guidance for users to switch to the supported "node" runtime.
packages/core/src/v3/build/runtime.ts (3)
10-12: Correctly updated runtime binary resolutionThe binary resolution logic has been updated to rename "node-22" to "node-test" while removing Bun support, aligning with the PR objectives.
20-22: Correctly updated execution path resolutionThe execution path resolution logic has been updated to rename "node-22" to "node-test" while removing Bun support, maintaining consistency across the codebase.
39-41: Correctly updated execution options logicThe execution options logic has been updated to rename "node-22" to "node-test" while removing Bun support, completing the runtime transition.
packages/cli-v3/src/deploy/buildImage.ts (3)
476-480: Effective code reuse through constantsGood refactoring by extracting the Node 21 image reference into a constant and reusing it for both runtimes. This makes future updates to the Node image version easier to maintain.
481-484: Successfully removed Bun runtime referencesThe BASE_IMAGE mapping has been updated to only include "node" and "node-test" entries, both pointing to the Node 21 image. This change aligns with the PR objective to remove experimental Bun runtime support.
489-494: Properly consolidated runtime handlingThe switch statement now correctly handles both "node" and "node-test" cases with the same implementation, which aligns with the PR objective stating "node-test runtime now points to the same image as node".
The only supported runtime is now
node(Node 21). Thenode-testruntime points at the same image and will only be used internally for testing before adding new node versions.Closes: #1191
Closes: #1671
Summary by CodeRabbit
New Features
Bug Fixes
Documentation
Chores