Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add wrapper to display attribution #137

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jmartsch
Copy link

Some services like Google Places require to display an attribution. The current version does not support this, as it only has an UL element to render the results to. My version adds a wrapper around the list, and gives options to insert custom markup before or after the list.
I also removed the styling from the script as it belongs to CSS imho.

The CSS could look like this:

.autocomplete-result-list{
  position: absolute;
  z-index: 1;
  width: 100%;
  box-sizing: border-box;
  display: none;
  top: 100%;
}
.autocomplete-result-list.visible{
  display: block;
}

when the result list is opened, the visible class is added to it.

Some services like Google Places require to display an attribution. The current version does not support this, as it only has an UL element to render the results to. My version adds a wrapper around the list, and gives options to insert custom markup before or after the list.
I also removed the styling from the script as it belongs to CSS imho.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant