Add hana scenario for hana_scale up cluster type #23
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pr updates all existing checks by adding
hana_scenario: performance_optimized
to all existing hana_scale_up related checks.This change is required for the new hana scale up scenario discovery.
Previously we only had hana scale up performance optimized checks, with the discovery of the cost opt scenario in
#3206 and 3152.
The new rule is like this:
When a check has a metadata and a cluster_type property
Check will be shown in a hana scale up cluster --> cost opt and performance opt scenario
When a check has a hana_scenario property in addition:
Check will be shown only in a hana scale up cost opt scenario.
When a a check has a hana_scenario property
Check will be shown only in a hana scale up performance opt scenario.