Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hana scenario for hana_scale up cluster type #23

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

EMaksy
Copy link
Member

@EMaksy EMaksy commented Dec 16, 2024

Description

This pr updates all existing checks by adding hana_scenario: performance_optimized to all existing hana_scale_up related checks.
This change is required for the new hana scale up scenario discovery.
Previously we only had hana scale up performance optimized checks, with the discovery of the cost opt scenario in
#3206 and 3152.

The new rule is like this:

When a check has a metadata and a cluster_type property

  target_type: cluster  
  cluster_type: 
    - hana_scale_up

Check will be shown in a hana scale up cluster --> cost opt and performance opt scenario

When a check has a hana_scenario property in addition:

  cluster_type: 
    - hana_scale_up
  hana_scenario: cost_optimized

Check will be shown only in a hana scale up cost opt scenario.

When a a check has a hana_scenario property

  cluster_type: 
    - hana_scale_up
  hana_scenario: performance_optimized

Check will be shown only in a hana scale up performance opt scenario.

@EMaksy EMaksy added the enhancement New feature or request label Dec 16, 2024
@EMaksy EMaksy self-assigned this Dec 16, 2024
@EMaksy EMaksy requested a review from dottorblaster December 16, 2024 12:18
@EMaksy EMaksy marked this pull request as ready for review December 16, 2024 14:20
@EMaksy EMaksy requested a review from CDimonaco December 16, 2024 15:32
@EMaksy EMaksy merged commit 37167dd into main Dec 17, 2024
6 checks passed
@EMaksy EMaksy deleted the add_hana_scenario_to_metadata branch December 17, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

2 participants