Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(select): add an option to not allow deselecting a selected option #225

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

HabRonan
Copy link
Contributor

@HabRonan HabRonan commented Dec 6, 2024

  • add a preventDeselection flag for single select so a user isn't allowed to deselect a previously selected option, they can only change it to another option. This is needed in the locale(Language) selection where one language needs to be selected.

Copy link

vercel bot commented Dec 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
boemly ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 6, 2024 2:44pm

Copy link

github-actions bot commented Dec 6, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
dist/boemly.cjs.production.min.js 1.56 MB (0%) 32 s (0%) 1.6 s (+3.27% 🔺) 33.5 s
dist/boemly.esm.js 71.86 KB (0%) 1.5 s (0%) 288 ms (+73.21% 🔺) 1.8 s

@HabRonan HabRonan force-pushed the ha/select-prevent-deselection-flag branch from 7621dd1 to c1f7962 Compare December 6, 2024 14:41
Copy link
Contributor

@ClaraTschamon ClaraTschamon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice code 😎

Copy link
Contributor

@rschiffer rschiffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@HabRonan HabRonan merged commit ee6f383 into main Dec 9, 2024
10 checks passed
@HabRonan HabRonan deleted the ha/select-prevent-deselection-flag branch December 9, 2024 09:00
Copy link

github-actions bot commented Dec 9, 2024

🎉 This PR is included in version 7.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants