fix: update text-with-icon #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
size-limit report 📦
|
lukasbals
approved these changes
Oct 28, 2024
Comment on lines
+48
to
+52
| const ButtonElement = button && ( | ||
| <Button mt="auto" size="lg" onClick={button.onClick} maxWidth="24"> | ||
| {button.text} | ||
| </Button> | ||
| ); |
There was a problem hiding this comment.
Suggested change
| const ButtonElement = button && ( | |
| <Button mt="auto" size="lg" onClick={button.onClick} maxWidth="24"> | |
| {button.text} | |
| </Button> | |
| ); | |
| const ButtonElement = ( | |
| <Button mt="auto" size="lg" onClick={button.onClick} maxWidth="24"> | |
| {button?.text} | |
| </Button> | |
| ); |
What do you think about this? It's more elegant IMO. But I don't mind too much.
There was a problem hiding this comment.
this doesn't work unfortunately, it displays a button without text even if the button is not defined in slice
|
🎉 This PR is included in version 6.2.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.