Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(tag): implement closable option #215

Merged
merged 1 commit into from
Oct 1, 2024
Merged

feat(tag): implement closable option #215

merged 1 commit into from
Oct 1, 2024

Conversation

ClaraTschamon
Copy link
Contributor

No description provided.

@vercel Vercel
Copy link

vercel bot commented Sep 30, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
boemly ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 1, 2024 6:40am

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 30, 2024 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
dist/boemly.cjs.production.min.js 1.56 MB (0%) 32 s (0%) 952 ms (+1.78% 🔺) 32.9 s
dist/boemly.esm.js 71.86 KB (0%) 1.5 s (0%) 130 ms (+19.77% 🔺) 1.6 s

raulsteurer
raulsteurer reviewed Sep 30, 2024
View reviewed changes
Copy link
Contributor

@raulsteurer raulsteurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This commit is not a feature since it does not change anything that requires a new release on npm. You can use docs: for commits that only change the documentation

@ClaraTschamon ClaraTschamon force-pushed the ct/closable-tag-option branch 4 times, most recently from 0d752a5 to ca484e0 Compare September 30, 2024 13:56
lukasbals
lukasbals reviewed Sep 30, 2024
View reviewed changes
Copy link
Member

@lukasbals lukasbals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good already.

Please update the commit message tofeat(boemly-tag): ...

src/components/BoemlyTag/BoemlyTag.tsx Outdated Show resolved Hide resolved
@ClaraTschamon ClaraTschamon force-pushed the ct/closable-tag-option branch from 5a0b179 to e1382a5 Compare October 1, 2024 06:39
@ClaraTschamon ClaraTschamon merged commit 1e30161 into main Oct 1, 2024
8 checks passed
@ClaraTschamon ClaraTschamon deleted the ct/closable-tag-option branch October 1, 2024 06:45
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 1, 2024

🎉 This PR is included in version 6.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukasbals lukasbals lukasbals approved these changes

@HabRonan HabRonan Awaiting requested review from HabRonan

@lialila lialila Awaiting requested review from lialila

@raulsteurer raulsteurer Awaiting requested review from raulsteurer

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ClaraTschamon @lukasbals @raulsteurer