Lazily invoke findLibrary to avoid UnsatisfiedLinkError when service loaded SymbolLookup successfuly found library #152
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIX #81
The problem in ChainedLibraryLookup.get comes from the fact findLibrary is invoked eagerly, thus leading to UnsatisfiedLinkError even when SymbolLookup never requires using the SymbolLookup returned by findLibrary. Actually, the solution is quite simple and it's inspired by the initialization of the lookup local variable.
It leverages the fact SymbolLookup is a FunctionalInterface to implement it in Lazily manner. All you need to do is replace the following line:
return lookup.or(findLibrary(arena)).or(Linker.nativeLinker().defaultLookup());
With the following line
return lookup.or((name) -> findLibrary(arena).find(name)).or(Linker.nativeLinker().defaultLookup());
Notice that now findLibrary will only execute if all SymbolLookup loaded by ServiceLoader failed to lookup the library.