Add test case for annotation processor option with space

Add a test to reproduce bazelbuild/bazel#19360 Fixes google#272 COPYBARA_INTEGRATE_REVIEW=google#272 from guw:main b2b7c2b PiperOrigin-RevId: 564447484
treblereel · Sep 28, 2023 · 6d7838f · 6d7838f
1 parent c606948
commit 6d7838f
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 8 deletions.
diff --git a/java/com/google/turbine/options/TurbineOptionsParser.java b/java/com/google/turbine/options/TurbineOptionsParser.java
@@ -18,8 +18,6 @@
 
 import static com.google.common.base.Preconditions.checkArgument;
 
-import com.google.common.base.CharMatcher;
-import com.google.common.base.Splitter;
 import com.google.common.collect.ImmutableList;
 import com.google.turbine.options.TurbineOptions.ReducedClasspathMode;
 import java.io.IOException;
@@ -159,9 +157,6 @@ private static void parse(TurbineOptions.Builder builder, Deque<String> argument
     }
   }
 
-  private static final Splitter ARG_SPLITTER =
-      Splitter.on(CharMatcher.breakingWhitespace()).omitEmptyStrings().trimResults();
-
   /**
    * Pre-processes an argument list, expanding arguments of the form {@code @filename} by reading
    * the content of the file and appending whitespace-delimited options to {@code argumentDeque}.
@@ -186,7 +181,7 @@ private static void expandParamsFiles(Deque<String> argumentDeque, Iterable<Stri
         if (!Files.exists(paramsPath)) {
           throw new AssertionError("params file does not exist: " + paramsPath);
         }
-        expandParamsFiles(argumentDeque, ARG_SPLITTER.split(Files.readString(paramsPath)));
+        expandParamsFiles(argumentDeque, Files.readAllLines(paramsPath));
       } else {
         argumentDeque.addLast(arg);
       }

diff --git a/javatests/com/google/turbine/options/TurbineOptionsTest.java b/javatests/com/google/turbine/options/TurbineOptionsTest.java
@@ -193,7 +193,15 @@ public void optionalTargetLabel() throws Exception {
   public void paramsFile() throws Exception {
     Iterable<String> paramsArgs =
         Iterables.concat(
-            BASE_ARGS, Arrays.asList("--javacopts", "-source", "8", "-target", "8", "--"));
+            BASE_ARGS,
+            Arrays.asList(
+                "--javacopts",
+                "-source",
+                "8",
+                "-target",
+                "8",
+                "-Aconnector.opt=with,space, here",
+                "--"));
     Path params = tmpFolder.newFile("params.txt").toPath();
     Files.write(params, paramsArgs, StandardCharsets.UTF_8);
 
@@ -206,7 +214,9 @@ public void paramsFile() throws Exception {
     TurbineOptions options = TurbineOptionsParser.parse(Arrays.asList(lines));
 
     // assert that options were read from params file
-    assertThat(options.javacOpts()).containsExactly("-source", "8", "-target", "8").inOrder();
+    assertThat(options.javacOpts())
+        .containsExactly("-source", "8", "-target", "8", "-Aconnector.opt=with,space, here")
+        .inOrder();
     // ... and directly from the command line
     assertThat(options.targetLabel()).hasValue("//custom/label");
   }