Support 475 Iceberg Glue REST endpoint support#98
Open
miniway wants to merge 1 commit intohotfix-423from
Open
Conversation
yajirobee
reviewed
Jan 13, 2026
There was a problem hiding this comment.
I have several questions.
- It seems the majority of changes are for trino-hive, trino-iceberg and libraries (particularly trino-parquet and trino-filesystem*). I suppose only trino-main and trino-spi changes impact td-trino, i.e. td-trino has no dependency for trino-{hive,iceberg} and updated libraries. Is it correct?
- Are all changes backport from 475? or are there any new code?
- If this is true, I suppose we don't need to re-patch when we'll upgrade trino version. We can just use the latest code.
- Do we want to merge this change into
hotfix-423now? or keep this PR open until we decide to proceed with this approach? I think we need further changes to load Iceberg catalog configuration dynamically. (or can it be implemented on td-trino side?)
yajirobee
approved these changes
Jan 15, 2026
Member
Author
Yes, you're right.
Mostly. Only one thing is a bridge on RowBlock (RowType data presentation) In 423, it's a sparse implementation which doesn't store null in elements' data block. Memory efficient? Complex to handle elements' data.
We can simply remove the bridge at the time Trino core upgrade.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is new approach that directly modify trino-hive and some base classes to make trino-iceberg based on trino 475 that supports iam role STS.
Because it was hell of dependency to address when I copied full modules under trino-iceberg
Unless it modifies SPI or trino-main a lot(?), it would not break td-trino.