Skip to content

⚡ Bolt: Use sync.Pool for bytes.Buffer in middleware wrappers - #400

Open
rschumann wants to merge 1 commit into
mainfrom
bolt-optimize-middleware-buffers-16301069927998937400
Open

⚡ Bolt: Use sync.Pool for bytes.Buffer in middleware wrappers#400
rschumann wants to merge 1 commit into
mainfrom
bolt-optimize-middleware-buffers-16301069927998937400

Conversation

@rschumann

Copy link
Copy Markdown
Contributor

💡 What: Replaced per-request bytes.Buffer allocation with sync.Pool in ResponseWriterWrapper and ResponseRewriter middleware, with Release() functions to recycle buffers.
🎯 Why: To reduce allocations in hot API paths and minimize GC pressure, as gin.ResponseWriter wrappers were constantly allocating buffers for each request/response.
📊 Impact: Reduces allocations from 1 to 0 per operation and cuts processing time from ~60ns to ~30ns per operation, significantly improving throughput under load.
🔬 Measurement: Benchmarked BenchmarkWithoutPool (1 alloc, 62.65 ns/op) vs BenchmarkWithPool (0 allocs, 31.49 ns/op).


PR created automatically by Jules for task 16301069927998937400 started by @rschumann

Replaced per-request bytes.Buffer allocation with sync.Pool in ResponseWriterWrapper and ResponseRewriter middleware, with Release() functions to recycle buffers.

Co-authored-by: rschumann <360788+rschumann@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant