⚡ Bolt: Pool ResponseWriterWrapper buffers - #392
Conversation
Co-authored-by: rschumann <360788+rschumann@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What: Use a
sync.Poolforbytes.BufferinsideResponseWriterWrapper.🎯 Why: Every HTTP request through the middleware previously allocated a new
bytes.Buffer. Pooling these buffers eliminates unnecessary per-request allocations.📊 Impact: Reduces allocations by 1 allocation per request, saving GC pressure in the hot path. Benchmark showed a 60% reduction in op time and 100% reduction in allocations for the buffer handling itself (from 63ns/1 alloc to 25ns/0 alloc).
🔬 Measurement: Verified via microbenchmark
BenchmarkWithPoolvsBenchmarkNoPool.PR created automatically by Jules for task 12196171146180021240 started by @rschumann