⚡ Bolt: Use sync.Pool for Response Writer buffers - #371
Conversation
Co-authored-by: rschumann <360788+rschumann@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What: Added a
sync.Poolto recyclebytes.Bufferobjects used for capturing response bodies inResponseWriterWrapper.🎯 Why: The response writer middleware allocates a new
bytes.Bufferfor every non-streaming HTTP response to capture the body for logging. In a high-throughput API gateway, this causes significant GC pressure and unnecessary heap allocations.📊 Impact: Reduces memory allocations by reusing buffers across requests. Enforces a 128KB capacity limit before returning to the pool to prevent memory bloat from occasional large responses.
🔬 Measurement: Verified via benchmark (
BenchmarkResponseWriterWrapperAllocation) showing the optimized path performs at 17 allocs/op, successfully recycling buffers to reduce overall GC overhead.PR created automatically by Jules for task 3840750659288324015 started by @rschumann