Add RSA key parameter support #315
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AleksaMCode
commented
Sep 21, 2024
| * - default_key_size {number} default: 1024 the key size in bit | ||
| * - default_public_exponent {string} default: '010001' the hexadecimal representation of the public exponent | ||
| * - log {boolean} default: false whether log warn/error or not | ||
| * @constructor | ||
| */ | ||
| export class JSEncrypt { | ||
| constructor(options: IJSEncryptOptions = {}) { | ||
| options = options || {}; |
There was a problem hiding this comment.
I removed this as it was redundant due to the utilization of the default parameter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the
JSEncryptRSAKeyalready supported the usage of key objects in its constructor ({ n: parseBigInt("nValue", 16), e: parseInt("eValue", 16), };), it only made sense to changeJSEncryptto allow usage of said key objects with parameters as well.Closes #146
Closes #212