Use a struct for the OOK configuration and add frequency tuning#124
Open
docprofsky wants to merge 2 commits intomasterfrom
Open
Use a struct for the OOK configuration and add frequency tuning#124docprofsky wants to merge 2 commits intomasterfrom
docprofsky wants to merge 2 commits intomasterfrom
Conversation
Owner
|
I like that this adds some legibility to the OOK configuration, and also that it supports cleanly mixing OOK signals that are on different frequencies or at different rates. The additional consumption of code memory shouldn't be much of a problem. Any volunteers to review this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use a struct store the configuration information for the OOK app. This adds the frequency to the configuration so that devices on different frequencies can be controlled.
Additionally, some minor cleaning up of the code is done.