Improve logging in RADIUS server and client #244
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RoadRunnr
reviewed
Apr 28, 2025
Comment on lines
438
to
446
| try | ||
| IP = get_ip(Addr), | ||
| ets:insert(?MODULE, {{IP, Port}, Retries, Retries}) | ||
| catch error:badarg -> | ||
| ?LOG(error, "Can't resolve hostname - ~p", [Addr]) | ||
| end; |
Member
There was a problem hiding this comment.
I know that other places use the try around get_ip too, but that is just because get_ip/1 is not really the right fit for those.
It would IMHO be far better to change the return of get_ip/1 to {ok, IP}|{error, Error} and change the 3 places in this file that use it to handle that return properly.
Member
Author
There was a problem hiding this comment.
I thought about it but as get_ip is a part of public API I decided to not changeat least in this PR to not affect potential callers
RoadRunnr
previously approved these changes
Apr 28, 2025
Member
RoadRunnr
left a comment
RoadRunnr
left a comment
There was a problem hiding this comment.
approved as is, although I would prefer if you could change the try around get_ip
vkatsuba
approved these changes
Apr 28, 2025
This commit provides the following improvements for the logging: 1. Switch to info from debug in the logging messages for the incoming requests and outgoing responses. There is no big sense in these messages anyway if everything is normal but more useful during debugging process. 2. Add logging to the RADIUS client if hostname can not be resolved. The log messages are added only to the place where we handle secondary/failover RADIUS servers to not spam with such messages. 3. Remove additional log message for the outgoing response. We already have such message from the point 1 which has everything what the removed message had except the RADIUS server name.
vkatsuba
approved these changes
Apr 28, 2025
RoadRunnr
approved these changes
Apr 29, 2025
vkatsuba
approved these changes
Apr 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit provides the following improvements for the logging: