Migrate storage implementations to Appender lifecycle model #482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlCutter
force-pushed
the
options_to_tessera
branch
from
6a6e039 to
6f7861d
Compare
mhutchinson
reviewed
Feb 12, 2025
lifecycle.go
Outdated
Comment on lines
95
to
91
| // NewCPFunc is the signature of a function which knows how to format and sign checkpoints. | ||
| type NewCPFunc func(size uint64, hash []byte) ([]byte, error) | ||
|
|
||
| // ParseCPFunc is the signature of a function which knows how to verify and parse checkpoints. | ||
| type ParseCPFunc func(raw []byte) (*f_log.Checkpoint, error) | ||
|
|
||
| // EntriesPathFunc is the signature of a function which knows how to format entry bundle paths. | ||
| type EntriesPathFunc func(n uint64, p uint8) string | ||
|
|
||
| // AppendOptions holds optional settings for all storage implementations. | ||
| type AppendOptions struct { |
There was a problem hiding this comment.
I'm not immediately convinced that all of these need to be publicly exposed from the API?
There was a problem hiding this comment.
I've removed the func types for now, we can figure out whether/how to reintroduce in a less polluting way later on.
AppendOptions needs to be exported so that storage impls can accept it, but again I think we can return to this and see if there's a better way/place - the primary goal of this PR is just to get us over the mark of broadly adopting the lifecycle API changes as it's blocking other work.
AlCutter
force-pushed
the
options_to_tessera
branch
2 times, most recently
from
adced4d to
c103690
Compare
AlCutter
changed the title
AlCutter
force-pushed
the
options_to_tessera
branch
6 times, most recently
from
921ded2 to
467967e
Compare
AlCutter
force-pushed
the
options_to_tessera
branch
from
467967e to
58ee74a
Compare
AlCutter
force-pushed
the
options_to_tessera
branch
from
58ee74a to
1587d48
Compare
AlCutter
force-pushed
the
options_to_tessera
branch
from
1587d48 to
2f32046
Compare
mhutchinson
reviewed
Feb 13, 2025
mhutchinson
reviewed
Feb 13, 2025
mhutchinson
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves all the of the storage implementations fully over to the lifecycle model introduced in #433.
The functionality related to managing an append-only log, which was previously present on the drivers themselves, is moved to a new
Appendertype. While there have been a few small refactors and tweaks to make the transition easier/cleaner, no functional changes in the way each of the drivers manages append-only logs is intended.StorageOptionsfunctionality has been moved intotesseraand merged with the newappendOptionsstruct introduced in #443.Towards #471 #472 #473 #474