Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable CSRF protection in grant (OAuth2) #5504

Merged
merged 2 commits into from
Nov 11, 2024
Merged

Enable CSRF protection in grant (OAuth2) #5504

merged 2 commits into from
Nov 11, 2024

Commits on Nov 8, 2024

  1. Enable CSRF protection in grant (OAuth2) 

    I've been doing some testing and from what I can see, this is already supported in https://github.com/simov/grant (which companion uses for OAuth2), when enabling the `state` parameter. It seems to be working and it is checking the parameter when redirected back from the provider: https://github.com/simov/grant/blob/61fe48a8dac6aa4ec5764fadff0898b743b85588/lib/flow/oauth2.js#L72So
    @mifi
    mifi committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    52d8fe2 View commit details
    Browse the repository at this point in the history

  2. fix test

    @mifi
    mifi committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    c00a44b View commit details
    Browse the repository at this point in the history