Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix Golden Retriever service worker import #5425

Merged
merged 2 commits into from
Aug 22, 2024
Merged

docs: fix Golden Retriever service worker import #5425

merged 2 commits into from
Aug 22, 2024

Conversation

mkabatek
Copy link
Contributor

@mkabatek mkabatek commented Aug 22, 2024 •
edited
Loading

Updated Golden Retriever documentation so that sw.js import works properly. Otherwise service worker throws an error on registration:

TypeError: import() is disallowed on ServiceWorkerGlobalScope by the HTML specification.

Reported here: #5424

@mkabatek
Update golden-retriever.mdx
bc8d016 
Updated Golden Retriever documentation so that sw.js import works properly.
@mkabatek mkabatek mentioned this pull request Aug 22, 2024
Closed
2 tasks
@github-actions GitHub Actions
Copy link
Contributor

Diff output files 
No diff

Murderlon
Murderlon approved these changes Aug 22, 2024
View reviewed changes
Copy link
Member

@Murderlon Murderlon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@Murderlon Murderlon changed the title Update golden-retriever.mdx docs: fix Golden Retriever service worker import Aug 22, 2024
@Murderlon
Copy link
Member

Prettier fails in CI though

@mkabatek
Copy link
Contributor Author

mkabatek commented Aug 22, 2024 •
edited
Loading

Prettier fails in CI though

Fixed, was missing a semicolon in the code block markdown.

@Murderlon Murderlon merged commit fcae803 into transloadit:main Aug 22, 2024
17 checks passed
@mkabatek mkabatek deleted the patch-1 branch August 22, 2024 13:33
@github-actions github-actions bot mentioned this pull request Aug 26, 2024
Merged
github-actions bot added a commit that referenced this pull request Aug 26, 2024
@github-actions
Release: [email protected] (#5430)
0a78023 
| Package     | Version | Package     | Version |
| ----------- | ------- | ----------- | ------- |
| @uppy/react |   4.0.2 | uppy        |   4.2.1 |

- @uppy/react: fix `use-sync-external-store` import (Merlijn Vos / #5426)
- docs: fix Golden Retriever service worker import (mkabatek / #5425)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Murderlon Murderlon Murderlon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mkabatek @Murderlon