Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@uppy/companion: migrate from Jest to node:test #3979

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Aug 15, 2022

Tests are not passing, I figured I should open it as a draft PR and leave it as it for now, we might want to come back to it at a later time.
The upside of node:test in comparison to Jest is that's it's much simpler, doesn't create its own env (and therefore avoid running into issues specific to the test runner rather than the actual code), and would support whatever Node.js itself support – including ESM packages.

@Murderlon
Copy link
Member

I think it's likely that we'll move to Vitest for all tests in the Uppy repo. If that happens, I'd rather have Companion on Vitest too, instead of a different test runner just for Companion.

@aduh95
Copy link
Contributor Author

aduh95 commented Aug 15, 2022

I think it's likely that we'll move to Vitest for all tests in the Uppy repo. If that happens, I'd rather have Companion on Vitest too, instead of a different test runner just for Companion.

Note that Companion is running on a different env already (jsdom vs node), so it can't be consistent all the way anyway.

@socket-security
Copy link

New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
expect 28.1.3 eval +28 1.63 MB simenb
supertest 6.2.4...6.3.3 network +4/-2 1.29 MB titanism

🚮 Removed packages: [email protected]

@kvz kvz assigned Murderlon and unassigned aduh95 Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants