improve TransloaditError #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add `cause` to TranslodaitError which is the response body - deprecate `transloaditErrorCode` (use `cause.error`) - deprecate `response?.body` (use `cause`) - deprecate `assemblyId` (use `cause.assembly_id`) - make sure errors thrown when status 200 but with `body.error` are also TransloaditError
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #210 +/- ##
==========================================
+ Coverage 68.75% 69.72% +0.97%
==========================================
Files 6 6
Lines 624 644 +20
Branches 123 129 +6
==========================================
+ Hits 429 449 +20
Misses 195 195
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
remcohaszing
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
causeto TranslodaitError which is the response bodytransloaditErrorCode(usecause.error)response?.body(usecause)assemblyId(usecause.assembly_id)body.errorare also TransloaditError