Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove async assembly #94

Merged
merged 5 commits into from
Jan 13, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,19 @@
### Not released yet ###
#### Major Release
* Exchange the Socket based assembly status fetching with a Server-Sent-Events (SSE) solution.
* Added new methods to the AssemblyListener interface to provide more information about the assembly status. e.g. encoding progress with AssemblyListener#onAssemblyProgress().
* Changed existing methods in the AssemblyListener interface to provide the bare JSON response from the api instead of pre-parsed data.
* Removed the deprecated AsyncAssemblies class and functionality.

##### Breaking Changes - Upgrade Guide
* The AssemblyListener interface has been upgraded. As a result you will have to implement the following methods:
- `onFileUploadFinished(JSONObject uploadInformation);`
- `onAssemblyProgress(JSONObject progress)`
- `onAssemblyResultFinished(JSONArray result)`

* The AsyncAssembly class has been removed. If you were using it, you will have to switch to the regular Assembly class.
It has been extended with asynchronous upload capabilities in the past.
The Example under `examples/src/main/java/com/transloadit/examples/MultiStepProcessing.java` shows how to use the new features.
### 1.0.1 / 2024-11-28 ###
* Added SDK support for generating signed Smart CDN URLs (see https://transloadit.com/docs/topics/signature-authentication/#smart-cdn).
This functionality ships as Transloadit#getSignedSmartCDNUrl() - Method.
Expand Down

This file was deleted.

This file was deleted.

This file was deleted.

9 changes: 0 additions & 9 deletions src/main/java/com/transloadit/sdk/Assembly.java
Original file line number Diff line number Diff line change
Expand Up @@ -819,13 +819,4 @@ protected String obtainUploadUrlSuffix() {
return "/assemblies/" + assemblyId;
}
}

/**
* Returns the current Thread List.
*
* @return List of Type TusUploadRunnable
*/
protected ArrayList<TusUploadRunnable> getThreadList() {
return threadList;
}
}
28 changes: 0 additions & 28 deletions src/main/java/com/transloadit/sdk/Transloadit.java
Original file line number Diff line number Diff line change
@@ -1,8 +1,5 @@
package com.transloadit.sdk;

import com.transloadit.sdk.async.AssemblyProgressListener;
import com.transloadit.sdk.async.UploadProgressListener;
import com.transloadit.sdk.async.AsyncAssembly;
import com.transloadit.sdk.exceptions.RequestException;
import com.transloadit.sdk.exceptions.LocalOperationException;
import com.transloadit.sdk.response.AssemblyResponse;
Expand Down Expand Up @@ -213,31 +210,6 @@ public Assembly newAssembly() {
return new Assembly(this);
}

/**
* Returns an AsyncAssembly instance that can be used to create a new assembly asynchronously.
* This method is good for running assemblies in the background
*
* @param listener an implementation of {@link UploadProgressListener} to serve as a callback
* for the asynchronous assembly.
* @return {@link AsyncAssembly}
*/
public AsyncAssembly newAssembly(UploadProgressListener listener) {
return new AsyncAssembly(this, listener);
}

/**
* Returns an AsyncAssembly instance that can be used to create a new assembly asynchronously.
* This method is good for running assemblies in the background
*
* @param listener an implementation of {@link AssemblyProgressListener} to serve as a callback
* for the asynchronous assembly.
* @deprecated use {@link #newAssembly(UploadProgressListener)} instead
* @return {@link AsyncAssembly}
*/
public AsyncAssembly newAssembly(AssemblyProgressListener listener) {
return new AsyncAssembly(this, listener);
}

/**
* Returns a single assembly.
*
Expand Down

This file was deleted.

Loading
Loading