(rough draft) Highlight parameters of multi-line module, function signatures.#13
Open
voussoir wants to merge 1 commit into
Open
(rough draft) Highlight parameters of multi-line module, function signatures.#13voussoir wants to merge 1 commit into
voussoir wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I wanted to improve the syntax so that it would highlight the parameters inside a multi-line module signature. Before these changes, multi-line modules were unhighlighted or wrongly highlighted:
Now they look like this:
HOWEVER, I am quite sure I made some collateral damage in the sense that the original patterns captured the entire module/function definitions, and my patterns are more focused on getting the delimiters to highlight the stuff in the middle. I am really bad at understanding these tmlangs and basically copied some of Python's and then banged my head against the wall until it barely worked. I'm making this pull request to introduce the topic but if you close this and rewrite it yourself that'd be totally great with me.
Thanks very much for your time and effort.