Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug fixes; add dataset_test for example datasets #186

Merged
merged 3 commits into from
Dec 17, 2024
Merged

bug fixes; add dataset_test for example datasets #186

merged 3 commits into from
Dec 17, 2024

Conversation

ehwenk
Copy link
Collaborator

@ehwenk ehwenk commented Dec 16, 2024

  • a few bug fixes, identified in part by @hrlai
  • another issue uncovered by @hrlai indicated we really needed to run dataset_test on the traits.build example datasets - issue Add dataset tests #143

We missed a few tests that no longer ran because of changed function names, deprecated functions

And functions that are now in `austraits` were still listed in `_pkgdown.yml`
Add dataset_test for example datasets - includes allowing "output" folders and Readme files in data folders
@ehwenk ehwenk requested a review from dfalster December 16, 2024 23:41
@dfalster dfalster self-requested a review December 17, 2024 01:45
@ehwenk ehwenk merged commit 0f0517d into develop Dec 17, 2024
3 checks passed
@ehwenk ehwenk deleted the bug-fixes branch December 17, 2024 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants