Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error if no contexts #154

Merged
merged 4 commits into from
Dec 5, 2024
Merged

Error if no contexts #154

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
77cef40
Update testdata.R
ehwenk Feb 8, 2024
9429f36
Update testdata.R
ehwenk Mar 13, 2024
0a7b90b
Update testdata.R
ehwenk Mar 14, 2024
d345cba
Merge branch 'develop' into error-if-no-contexts
ehwenk Dec 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 17 additions & 8 deletions R/testdata.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -591,8 +591,14 @@ dataset_test_worker <-
)

# Check that there are no duplicate `var_in` or `context_property` fields
context_properties <- sapply(metadata[["contexts"]], "[[", "context_property")
context_vars_in <- sapply(metadata[["contexts"]], "[[", "var_in")

if(is.na(metadata[["contexts"]][1])) {
context_properties <- metadata[["contexts"]]
context_vars_in <- metadata[["contexts"]]
} else {
context_properties <- sapply(metadata[["contexts"]], "[[", "context_property")
context_vars_in <- sapply(metadata[["contexts"]], "[[", "var_in")
}

expect_equal(
context_properties |> duplicated() |> sum(),
Expand Down Expand Up @@ -731,12 +737,15 @@ dataset_test_worker <-
)

# Check units are found in `unit_conversions.csv`
units <- read_csv("config/unit_conversions.csv")
expect_is_in(
traits$unit_in, units$unit_from,
info = paste0(red(f), "\ttraits"),
label = "`unit_in`'s"
)
# This test is being commented out, because fails anytime columns are read in
# or anytime there are units not in unit_conversions because they are never converted.

#units <- read_csv("config/unit_conversions.csv")
#expect_is_in(
# traits$unit_in, units$unit_from,
# info = paste0(red(f), "\ttraits"),
# label = "`unit_in`'s"
#)

# Check no duplicate `var_in`'s

Expand Down
Loading