Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ontology bug #152

Closed
wants to merge 2 commits into from
Closed

Ontology bug #152

wants to merge 2 commits into from

Conversation

ehwenk
Copy link
Collaborator

@ehwenk ehwenk commented Feb 13, 2024 •
edited
Loading

Two things fixed:

  • Had written ontology to be slash-encoded (traits.build/terms), but the rules written into w3id.org/traits.build were for hash-encoding (traits.build#terms). Either is allowed and I don't have a strong preference so have switched all terms to hash-encoded, since these are the ones we just published.
  • I hadn't established a "topConcept" within the concept scheme. The concept scheme is "w3id.org/traits.build" and the topConceptOf this concept scheme is now established as "w3id.org/traits.build#traits.build-database"
  • Also added citation to preprint, since that is now up.

@ehwenk
change / to # throughout to match redirect terms
15b3d0d
@ehwenk
create "topConcept" for traits.build concept scheme
f61e012 
- had combined info about the concept scheme (traits.build) and the "top concept" in the concept scheme (traits.build-database). Realised this looking at use of a few key headers (topConceptIn vs hasTopConcept) and how they were used in APD
@ehwenk ehwenk requested a review from dfalster February 13, 2024 21:07
@dfalster dfalster closed this in dc2be95 Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dfalster dfalster Awaiting requested review from dfalster

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ehwenk