Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix order of inputs in net_mass_production_dt #389

Merged
merged 1 commit into from
May 20, 2024
Merged

Conversation

aornugent
Copy link
Collaborator

Addresses #378.

@aornugent aornugent requested a review from itowers1 February 27, 2024 23:55
@dfalster
Copy link
Member

Gah! I was initially surprised this didn't break anything, i.e. cause tests to fail. But we have generally set rates of bark and sapwood turnover to be equal, so the error wouldn't show up until you decoupled those rates.

How did you find this @aornugent >?

@aornugent
Copy link
Collaborator Author

@itowers1 found it! I just rediscovered it when looking at turnover in #380.

@aornugent aornugent requested a review from dfalster February 28, 2024 00:48
@dfalster dfalster merged commit 68805e3 into develop May 20, 2024
4 checks passed
@dfalster dfalster added this to the TF24 X Misc milestone May 20, 2024
@dfalster dfalster deleted the fix-turnover branch May 27, 2024 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants