Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extract add parameter for exact matches #156

Merged
merged 2 commits into from
Jan 21, 2025

Conversation

ehwenk
Copy link
Collaborator

@ehwenk ehwenk commented Jan 20, 2025

Add option to extract_ functions to only allow exact matches - versus the default which uses partial string matches.

There are instances where partial matches return too much data:

For instance

searching on trait = "leaf_area" returns data for "leaf_area" and "leaf_area_ratio"
searching for taxonomic_status = "accepted" also returns data for "genus accepted" and therefore more taxon names than are sought.

The default is still for partial matches, but there is now a parameter "partial_matches_allowed" which can be set to FALSE.

This branch also includes a different bug fix for extract_data

Add option to `extract_` functions to only allow exact matches
Bug fix in `extract_data` that turned up through AusFizz.
@ehwenk ehwenk requested a review from dfalster January 20, 2025 21:42
Copy link
Member

@dfalster dfalster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Just checking you want partial_matches_allowed=TRUE as default?

@ehwenk ehwenk merged commit e78c8fa into develop Jan 21, 2025
10 checks passed
@ehwenk ehwenk deleted the `extract_`-add-parameter-for-exact-matches branch January 21, 2025 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants