Bug fix #155
Merged
Bug fix #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix error - due to excluded_data table being a completely empty tibble rather than having empty columns if there is no excluded_data. Caused a problem with back-to-back extract_ function uses
Forgot I also needed a column "error" and added test.
dfalster
approved these changes
Jan 20, 2025
I'm going to look into this. I wanted to merge in the patch for now so that austraits works for others. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there was no data in the excluded_data table, the extract_ functions were returning an empty tibble, not a tibble of empty named, columns. In addition to being the wrong output, this was leading to warnings when running multiple extract_ functions.
A change at the end of the main extract_data function fixes this