bug fix #138
Merged
bug fix #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfalster
approved these changes
Nov 21, 2024
ehwenk
pushed a commit
that referenced
this pull request
Dec 8, 2024
* bug fix - join_location_properties, separate_trait_values (#138) - join_location_properties(format = "single_column_json") was not retaining location_name as its own column. * Both fixed this and added tests - Also, value_type was being lost during separate_trait_values - and probably has been for a long time. * Bump version (3.0.1) --------- Co-authored-by: Elizabeth Wenk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
join_location_properties(format = "single_column_json")was not retaininglocation_nameas its own column.Both fixed this and added tests
Also,
value_typewas being lost duringseparate_trait_values- and probably has been for a long time.