Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming files and parameters #119

Merged
merged 4 commits into from
Nov 13, 2024
Merged

Conversation

ehwenk
Copy link
Collaborator

@ehwenk ehwenk commented Nov 12, 2024

  • standardise file names
    
  • standardise parameter names
    
  • change all pipes to %>%
    

..no changes to functions, just file names being changed
- replace all `@param austraits` and `@param aus_traits` with `@param database`
- replace all references to just the traits table (previously x, data, trait( with `@param trait_data`
- standardise description of parameters - currently using `@param database traits.build database (list object)` so people realise it is a relational database, but could change to `@param database traits.build database`
Change all native pipes (|>) to %>% pipes
@ehwenk ehwenk requested review from dfalster and fontikar and removed request for dfalster November 12, 2024 23:24
Copy link
Member

@dfalster dfalster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

R/as_wide_table.R Show resolved Hide resolved
@ehwenk ehwenk merged commit 70e7671 into develop Nov 13, 2024
5 checks passed
@ehwenk ehwenk deleted the renaming-files-and-parameters branch November 13, 2024 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants