Skip to content
This repository has been archived by the owner on Sep 30, 2021. It is now read-only.

Commit

Permalink
v1.0.0 Release (#9)
Browse files Browse the repository at this point in the history 
* viztest against cran

* shorten url route in example

* run revdep

* update cran comments

* remove remotes for submission
  • Loading branch information
@schloerke
schloerke authored Apr 20, 2018
1 parent 138e48d commit ac65076
Show file tree
Hide file tree
Showing 6 changed files with 122 additions and 66 deletions.
3 changes: 0 additions & 3 deletions DESCRIPTION
View file
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,6 @@ Depends:
R (>= 3.1.0),
leaflet (>= 2.0.0),
leaflet.extras (>= 1.0.0)
Remotes:
rstudio/leaflet,
bhaskarvk/leaflet.extras
Encoding: UTF-8
LazyData: true
Imports:
Expand Down
5 changes: 4 additions & 1 deletion R/imageMapLayers.R
View file
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,10 @@ imageMapLayerOptions <- function(
#' addEsriBasemapLayer(esriBasemapLayers$Imagery) %>%
#' setView(-120.23, 43.5, 5) %>%
#' addEsriImageMapLayer(
#' url = "http://imagery.oregonexplorer.info/arcgis/rest/services/NAIP_2011/NAIP_2011_Dynamic/ImageServer",
#' url = paste0(
#' "http://imagery.oregonexplorer.info/arcgis/rest/services/",
#' "NAIP_2011/NAIP_2011_Dynamic/ImageServer"
#' ),
#' options = imageMapLayerOptions(bandIds = c(3, 0, 1)))
#'
#' ## for more examples see
Expand Down
68 changes: 60 additions & 8 deletions cran-comments.md
View file
Original file line number Diff line number Diff line change
@@ -1,16 +1,68 @@
This submission is in conjunction with the `leaflet` package submission.
# Comments

- Bhaskar
## 2018-4-20

This submission is in conjunction with the `leaflet` and `leaflet.extras` package submissions.

This submission is done by Barret Schloerke <[email protected]> on behalf of Bhaskar Karambelkar <[email protected]>. Please submit any changes to be made to <[email protected]>.

- Barret


## Test environments
* local OS X install, R 3.4.4
* local OS X install, R 3.4.4, --run-dontcheck
* 0 errors | 0 warnings | 0 notes
* ubuntu 12.04 (on travis-ci), R version 3.4.4 (2017-01-27)
* rhub
* Windows Server 2008 R2 SP1, R-devel, 32/64 bit
* https://builder.r-hub.io/status/leaflet.esri_1.0.0.tar.gz-bc7b8a1c70d745c7b483aab04013735d
* Windows Server 2008 R2 SP1, R-release, 32/64 bit
* https://builder.r-hub.io/status/leaflet.esri_1.0.0.tar.gz-ebcdd73cf3874be792acedd0eaf0d91a
* 0 errors | 0 warnings | 0 notes


I believe the warning and note below are transient within r-hub.
* NOTE: Unknown, possibly mis-spelled, fields in DESCRIPTION
* This field has been removed in submission build.
* Was needed to test with rhub directly as the development branch of leaflet was required.

* r-hub
* Platform: Windows Server 2008 R2 SP1, R-release, 32/64 bit
https://builder.r-hub.io/status/leaflet.esri_1.0.0.tar.gz-be09fad309974de3a0876f42510b3d4c
❯ checking CRAN incoming feasibility ... NOTE
Maintainer: 'Bhaskar Karambelkar <[email protected]>'

Unknown, possibly mis-spelled, fields in DESCRIPTION:
'Remotes'

0 errors ✔ | 0 warnings ✔ | 1 note ✖

* Platform: Windows Server 2008 R2 SP1, R-devel, 32/64 bit
https://builder.r-hub.io/status/leaflet.esri_1.0.0.tar.gz-79f802cdf0344332b88ae4770c001cc9
❯ checking CRAN incoming feasibility ... NOTE
Maintainer: 'Bhaskar Karambelkar <[email protected]>'

Unknown, possibly mis-spelled, fields in DESCRIPTION:
'Remotes'

0 errors ✔ | 0 warnings ✔ | 1 note ✖

* Platform: Ubuntu Linux 16.04 LTS, R-release, GCC
* checked with `_R_CHECK_FORCE_SUGGESTS_=0`
https://builder.r-hub.io/status/leaflet.esri_1.0.0.tar.gz-540540a8a42c4e2580c5842f0fbb77f7
❯ checking CRAN incoming feasibility ... NOTE
Maintainer: 'Bhaskar Karambelkar <[email protected]>'

Unknown, possibly mis-spelled, fields in DESCRIPTION:
'Remotes'

0 errors ✔ | 0 warnings ✔ | 1 note ✖

* Platform: Fedora Linux, R-devel, clang, gfortran
* checked with `_R_CHECK_FORCE_SUGGESTS_=0`
https://builder.r-hub.io/status/leaflet.esri_1.0.0.tar.gz-f2d5fa14ce41439ca85aad0bb09b3b9a
❯ checking CRAN incoming feasibility ... NOTE
Maintainer: 'Bhaskar Karambelkar <[email protected]>'

Unknown, possibly mis-spelled, fields in DESCRIPTION:
'Remotes'

0 errors ✔ | 0 warnings ✔ | 1 note ✖

## R CMD check results

Expand Down
5 changes: 4 additions & 1 deletion man/addEsriImageMapLayer.Rd
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

103 changes: 53 additions & 50 deletions revdep/README.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -8,59 +8,62 @@
|ui |X11 |
|language |(EN) |
|collate |en_US.UTF-8 |
|tz |America/Los_Angeles |
|date |2018-03-29 |
|tz |America/New_York |
|date |2018-04-20 |

# Dependencies

|package |old |new |Δ |
|:--------------|:-------|:-------|:--|
|leaflet.esri |0.2 |1.0.0 |* |
|assertthat |0.2.0 |0.2.0 | |
|base64enc |0.1-3 |0.1-3 | |
|cli |1.0.0 |1.0.0 | |
|colorspace |1.3-2 |1.3-2 | |
|crayon |1.3.4 |1.3.4 | |
|crosstalk |1.0.0 |1.0.0 | |
|dichromat |2.0-0 |2.0-0 | |
|digest |0.6.15 |0.6.15 | |
|ggplot2 |2.2.1 |2.2.1 | |
|glue |1.2.0 |1.2.0 | |
|gridExtra |2.3 |2.3 | |
|gtable |0.2.0 |0.2.0 | |
|htmltools |0.3.6 |0.3.6 | |
|htmlwidgets |1.0 |1.0 | |
|httpuv |1.3.6.2 |1.3.6.2 | |
|jsonlite |1.5 |1.5 | |
|labeling |0.3 |0.3 | |
|lazyeval |0.2.1 |0.2.1 | |
|leaflet |1.1.0 |2.0.0 |* |
|leaflet.extras |0.2 |1.0.0 |* |
|magrittr |1.5 |1.5 | |
|markdown |0.8 |0.8 | |
|mime |0.5 |0.5 | |
|munsell |0.4.3 |0.4.3 | |
|pillar |1.2.1 |1.2.1 | |
|plyr |1.8.4 |1.8.4 | |
|png |0.1-7 |0.1-7 | |
|R6 |2.2.2 |2.2.2 | |
|raster |2.6-7 |2.6-7 | |
|RColorBrewer |1.1-2 |1.1-2 | |
|Rcpp |0.12.16 |0.12.16 | |
|reshape2 |1.4.3 |1.4.3 | |
|rlang |0.2.0 |0.2.0 | |
|scales |0.5.0 |0.5.0 | |
|shiny |1.0.5 |1.0.5 | |
|sourcetools |0.1.6 |0.1.6 | |
|sp |1.2-7 |1.2-7 | |
|stringi |1.1.7 |1.1.7 | |
|stringr |1.3.0 |1.3.0 | |
|tibble |1.4.2 |1.4.2 | |
|utf8 |1.1.3 |1.1.3 | |
|viridis |0.5.1 |0.5.1 | |
|viridisLite |0.3.0 |0.3.0 | |
|xtable |1.8-2 |1.8-2 | |
|yaml |2.1.18 |2.1.18 | |
|package |old |new |Δ |
|:--------------|:--------|:--------|:--|
|leaflet.esri |0.2 |1.0.0 |* |
|assertthat |0.2.0 |0.2.0 | |
|base64enc |0.1-3 |0.1-3 | |
|BH |1.66.0-1 |1.66.0-1 | |
|cli |1.0.0 |1.0.0 | |
|colorspace |1.3-2 |1.3-2 | |
|crayon |1.3.4 |1.3.4 | |
|crosstalk |1.0.0 |1.0.0 | |
|dichromat |2.0-0 |2.0-0 | |
|digest |0.6.15 |0.6.15 | |
|ggplot2 |2.2.1 |2.2.1 | |
|glue |1.2.0 |1.2.0 | |
|gridExtra |2.3 |2.3 | |
|gtable |0.2.0 |0.2.0 | |
|htmltools |0.3.6 |0.3.6 | |
|htmlwidgets |1.2 |1.2 | |
|httpuv |1.4.0 |1.4.0 | |
|jsonlite |1.5 |1.5 | |
|labeling |0.3 |0.3 | |
|later |0.7.1 |0.7.1 | |
|lazyeval |0.2.1 |0.2.1 | |
|leaflet |1.1.0 |2.0.0 |* |
|leaflet.extras |0.2 |1.0.0 |* |
|magrittr |1.5 |1.5 | |
|markdown |0.8 |0.8 | |
|mime |0.5 |0.5 | |
|munsell |0.4.3 |0.4.3 | |
|pillar |1.2.1 |1.2.1 | |
|plyr |1.8.4 |1.8.4 | |
|png |0.1-7 |0.1-7 | |
|promises |1.0.1 |1.0.1 | |
|R6 |2.2.2 |2.2.2 | |
|raster |2.6-7 |2.6-7 | |
|RColorBrewer |1.1-2 |1.1-2 | |
|Rcpp |0.12.16 |0.12.16 | |
|reshape2 |1.4.3 |1.4.3 | |
|rlang |0.2.0 |0.2.0 | |
|scales |0.5.0 |0.5.0 | |
|shiny |1.0.5 |1.0.5 | |
|sourcetools |0.1.6 |0.1.6 | |
|sp |1.2-7 |1.2-7 | |
|stringi |1.1.7 |1.1.7 | |
|stringr |1.3.0 |1.3.0 | |
|tibble |1.4.2 |1.4.2 | |
|utf8 |1.1.3 |1.1.3 | |
|viridis |0.5.1 |0.5.1 | |
|viridisLite |0.3.0 |0.3.0 | |
|xtable |1.8-2 |1.8-2 | |
|yaml |2.1.18 |2.1.18 | |

# Revdeps

4 changes: 1 addition & 3 deletions scripts/viztest.R
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,4 @@ devtools::install_github("schloerke/viztest")
# source("scripts/viztest.R")


viztest::viztest(".", "bhaskarvk/leaflet.esri", resize = FALSE, stomp = TRUE)

# viztest::viztest(".", "bhaskarvk/leaflet.esri", resize = FALSE, stomp = TRUE, skip_old = TRUE)
viztest::viztest(".", "leaflet.esri", resize = FALSE, stomp = TRUE)

0 comments on commit ac65076

Please sign in to comment.