Skip to content

feat(instrumentation): Add milvus metrics support #3013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

feat(instrumentation): Add milvus metrics support #3013

wants to merge 4 commits into from

Conversation

DrishyaDas
Copy link

  • I have added tests that cover my changes.
  • If adding a new instrumentation or changing an existing one, I've added screenshots from some observability platform showing the change.
  • PR name follows conventional commits format: feat(instrumentation): ... or fix(instrumentation): ....
  • (If applicable) I have updated the documentation accordingly.

@CLAassistant
Copy link

CLAassistant commented Jun 16, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@DrishyaDas DrishyaDas force-pushed the feat/add-metrics-support-milvus branch 2 times, most recently from 61c08cc to 6bb3121 Compare June 16, 2025 08:24
@DrishyaDas DrishyaDas force-pushed the feat/add-metrics-support-milvus branch from 6bb3121 to 32afce7 Compare June 16, 2025 08:25
adharshctr
adharshctr suggested changes Jun 16, 2025
View reviewed changes
packages/opentelemetry-instrumentation-milvus/tests/test_search.py Outdated
@@ -124,6 +125,10 @@ def test_milvus_single_vector_search(exporter, collection):
assert (
span.attributes.get(SpanAttributes.MILVUS_SEARCH_RESULT_COUNT) == total_matches
)
metris_data = reader.get_metrics_data()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct the variable name

packages/opentelemetry-semantic-conventions-ai/opentelemetry/semconv_ai/__init__.py
@@ -21,6 +21,12 @@ class Meters:
PINECONE_DB_USAGE_READ_UNITS = "db.pinecone.usage.read_units"
PINECONE_DB_USAGE_WRITE_UNITS = "db.pinecone.usage_write_units"

MILVUS_DB_QUERY_DURATION = "db.milvus.query.duration"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to raise a new PR, if these are new semantic convention. Once it is released, you can use it here

packages/opentelemetry-instrumentation-milvus/opentelemetry/instrumentation/milvus/wrapper.py Outdated
shared_attributes,
response
):
print(response)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adharshctr adharshctr adharshctr requested changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DrishyaDas @CLAassistant @adharshctr