Define internal crates once in workspace.dependencies - #520
Open
ThierryCantin-Demers wants to merge 1 commit into
Open
Define internal crates once in workspace.dependencies#520ThierryCantin-Demers wants to merge 1 commit into
ThierryCantin-Demers wants to merge 1 commit into
Conversation
Member crates now use workspace = true for cubek-* dependencies, so a version bump edits one block instead of every manifest. Also fixes cubek-pool's stale 0.3.0-pre.1 pin on cubek-test-utils.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Member crates now declare cubek-* dependencies with
workspace = trueinstead of repeatingpath/versionin every manifest, matching how burn and cubecl handle their internal crates. A release bump now edits one block in the root manifest.Each dependency section lists the internal crates as their own group first, then the external ones.
Also fixes cubek-pool's stale
0.3.0-pre.1pin on cubek-test-utils, and adds explicitdefault-features = trueat the few sites whose bare path deps previously meant defaults-on, so resolved features are unchanged.Manifest-only refactor:
cargo check --workspace --all-targetsclean.