Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor unary + binary kernels #2665

Merged
merged 3 commits into from
Jan 7, 2025
Merged

Refactor unary + binary kernels #2665

merged 3 commits into from
Jan 7, 2025

Conversation

nathanielsimard
Copy link
Member

Removed some macros improving a bit compile time.

Before big refactor: 2m 56s
Before: 50.65s
After: 47.01s

Copy link

codecov bot commented Jan 6, 2025

Codecov Report

Attention: Patch coverage is 88.15029% with 41 lines in your changes missing coverage. Please review.

Project coverage is 83.16%. Comparing base (80e67b7) to head (fbdc2ed).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
crates/burn-jit/src/kernel/unary_float.rs 87.71% 14 Missing ⚠️
crates/burn-jit/src/kernel/unary_numeric.rs 88.09% 10 Missing ⚠️
crates/burn-jit/src/kernel/binary.rs 93.63% 7 Missing ⚠️
crates/burn-jit/src/tensor/base.rs 50.00% 4 Missing ⚠️
crates/burn-jit/src/kernel/clamp.rs 62.50% 3 Missing ⚠️
crates/burn-jit/src/ops/float_ops.rs 88.88% 2 Missing ⚠️
crates/burn-jit/src/ops/int_ops.rs 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2665      +/-   ##
==========================================
+ Coverage   83.14%   83.16%   +0.02%     
==========================================
  Files         839      840       +1     
  Lines      107913   107909       -4     
==========================================
+ Hits        89719    89739      +20     
+ Misses      18194    18170      -24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nathanielsimard nathanielsimard requested a review from laggui January 7, 2025 20:40
@laggui laggui merged commit 2b4be6c into main Jan 7, 2025
11 checks passed
@laggui laggui deleted the refactor/unary-binary branch January 7, 2025 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants