Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DisplayNameを追加 #741

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

DisplayNameを追加 #741

wants to merge 5 commits into from

Conversation

ZOI-dayo
Copy link
Contributor

close #700

UserにDisplayNameパラメータを追加しました。

  • DBのマイグレーション処理は書いています (v2 -> v3)
  • API部分に変更が発生したのですが、APIのバージョンは更新するべきでしょうか?
  • 未指定は空文字列で表せばよいと考え、DisplayNameはstringとして実装しているのですが、*stringなどNullを扱える型にすべきでしょうか?

Copy link

codecov bot commented Dec 26, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 21 lines in your changes missing coverage. Please review.

Project coverage is 70.85%. Comparing base (5eaab30) to head (bc020a4).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
internal/infrastructure/migration/v3.go 25.00% 8 Missing and 1 partial ⚠️
internal/domain/user.go 0.00% 6 Missing ⚠️
internal/infrastructure/repository/contest_impl.go 33.33% 2 Missing ⚠️
internal/infrastructure/repository/group_impl.go 0.00% 2 Missing ⚠️
internal/handler/project.go 50.00% 1 Missing ⚠️
internal/infrastructure/repository/project_impl.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #741      +/-   ##
==========================================
- Coverage   71.00%   70.85%   -0.15%     
==========================================
  Files          42       43       +1     
  Lines        4576     4601      +25     
==========================================
+ Hits         3249     3260      +11     
- Misses       1170     1188      +18     
+ Partials      157      153       -4     
Flag Coverage Δ
integration 70.85% <66.66%> (-0.15%) ⬇️
unit 70.85% <66.66%> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@H1rono H1rono requested a review from ras0q December 26, 2024 09:42
Copy link
Member

@ras0q ras0q left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

過去のPR出した人の怠慢で申し訳ないんですが、テーブルドキュメントの更新にこれと関係ない変更まで入っちゃってるのでレビューしやすくするためにそれだけ別PRに分けてもらっていいですか🙏(将来的にはCIで差分検知できると良さそうですね)
あとマイグレーションのv3が#739と被ってるのであっちがマージされ次第こっちをv4に書き換えてもらえると助かります

@ZOI-dayo
Copy link
Contributor Author

ありがとうございます! やります

@ras0q
Copy link
Member

ras0q commented Dec 26, 2024

(分かってるかもだけど一応)テーブルドキュメントはこのブランチではなくmain時点のものを出してもらいたいです、よろしくお願いします!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

userのdisplayNameが欲しい
2 participants