-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DisplayNameを追加 #741
base: main
Are you sure you want to change the base?
DisplayNameを追加 #741
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #741 +/- ##
==========================================
- Coverage 71.00% 70.85% -0.15%
==========================================
Files 42 43 +1
Lines 4576 4601 +25
==========================================
+ Hits 3249 3260 +11
- Misses 1170 1188 +18
+ Partials 157 153 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
過去のPR出した人の怠慢で申し訳ないんですが、テーブルドキュメントの更新にこれと関係ない変更まで入っちゃってるのでレビューしやすくするためにそれだけ別PRに分けてもらっていいですか🙏(将来的にはCIで差分検知できると良さそうですね)
あとマイグレーションのv3が#739と被ってるのであっちがマージされ次第こっちをv4に書き換えてもらえると助かります
ありがとうございます! やります |
(分かってるかもだけど一応)テーブルドキュメントはこのブランチではなくmain時点のものを出してもらいたいです、よろしくお願いします!! |
close #700
UserにDisplayNameパラメータを追加しました。