feat:自動でvalidationするCIを追加 #1203
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DiffNo diff detected! |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Kentaro1043
requested changes
Oct 17, 2025
Comment on lines
6
to
7
| - "renovate-bot.js" | ||
| - "renovate/**" |
Collaborator
There was a problem hiding this comment.
パスが違う気がします
Suggested change
| - "renovate-bot.js" | |
| - "renovate/**" | |
| - ".github/renovate-bot.js" | |
| - ".github/renovate/**" |
| validate: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v4 |
Collaborator
There was a problem hiding this comment.
最新にするのが良いです
https://github.com/actions/checkout/releases
Suggested change
| - uses: actions/checkout@v4 | |
| - uses: actions/checkout@v5 |
Collaborator
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
一応ちゃんと見ましたが、AIに任せた部分が多いので正しいか分からないです
#1109
質問
・.yamlの名前はvalidate-renovate-config.yamlでいいですか
・jobsの中のvalidateはcheckがいいですか(参考資料がcheckになっている)
・actions/checkout@v4よりもactions/checkout@v3の方がいいですか(参考資料がv3になっている)
・今は対象ファイルを二つのステップで分けていますが一つの方がいいですか