knoQのk8s移行 #1160
Open
knoQのk8s移行 #1160
+106
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kentaro1043
requested changes
Sep 11, 2025
Collaborator
Kentaro1043
left a comment
Kentaro1043
left a comment
There was a problem hiding this comment.
確認をお願いします🙏
これらを見つつ、先にknoq-devの用意をしていただけると助かります🙏
knoq/backend-deployment.yaml
Outdated
| apiVersion: apps/v1 | ||
| kind: Deployment | ||
| metadata: | ||
| name: knoq-backend |
Collaborator
There was a problem hiding this comment.
この辺の名前から-backendを削除して欲しいです（フロントエンドも実行されるので）
ファイル名からもお願いします🙏
knoq/ingress-route.yaml
Outdated
| secretName: knoq-tls | ||
|
|
||
| routes: | ||
| - match: (Host(`knoq.trap.jp`) && PathPrefix(`/api/`) |
Collaborator
There was a problem hiding this comment.
フロントエンドも同じコンテナで実行されるので、PathPrefixは必要ないです
あと余分な(が先頭についてます
| valueFrom: | ||
| secretKeyRef: | ||
| name: knoq-secrets | ||
| key: DB_PASSWORD |
Collaborator
There was a problem hiding this comment.
READMEに従って、この値を格納するSecretの用意をお願いします
わからなかったら聞いて下さい！
| @@ -0,0 +1,5 @@ | |||
| resources: | |||
Collaborator
There was a problem hiding this comment.
ファイル名ミス: kustomization.yamlです
knoq/backend-deployment.yaml
Outdated
| weight: 1 | ||
|
|
||
| containers: | ||
| - name: knoq-backend |
Collaborator
There was a problem hiding this comment.
フロントエンドのリポジトリをpullしてVolumeをアタッチするinitContainersの用意をお願いします
DiffNo diff detected! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
knoQのk8sを書きました。