assert vs require
#830
Merged
assert vs require
#830
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v2 #830 +/- ##
=====================================
Coverage 7.10% 7.11%
=====================================
Files 154 154
Lines 31130 31130
=====================================
+ Hits 2213 2215 +2
+ Misses 28783 28781 -2
Partials 134 134 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@Hueter57 他のところも全部 |
Hueter57
force-pushed
the
change_assert_to_require
branch
from
37b7066 to
ce9151e
Compare
|
コンフリクトが起きて前に教えてもらっていたコンフリクト解消の操作 (該当するtraQリンク in #team/SysAd/Jomon/server) をし忘れていたのでこの機会に行いました。 |
|
@Hueter57 |
H1rono
approved these changes
May 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#821
ひとまず
router/admin_test.goの中身のみ変更基本
assertをrequireに変更していったがHTTPステータスとresBodyの比較する部分はエラー時に両方見れた方がいいと思ったのでassertのままにしたresuireに変更する中で不要なif文を消した