Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correction webhook eventhandler #815

Open
wants to merge 6 commits into
base: v2
Choose a base branch
from

Conversation

Hueter57
Copy link
Contributor

@Hueter57 Hueter57 commented Dec 6, 2024

#769

TransactionTransactionNewCreateTransactionCorrectionに分離

webhook.goも構造体を分け、POSTとPUTで処理を分けた

Copy link

codecov bot commented Dec 6, 2024

Codecov Report

Attention: Patch coverage is 5.12821% with 111 lines in your changes missing coverage. Please review.

Project coverage is 25.23%. Comparing base (7a76319) to head (0a6e6f0).

Files with missing lines Patch % Lines
service/webhook.go 0.00% 111 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##               v2     #815      +/-   ##
==========================================
- Coverage   25.25%   25.23%   -0.02%     
==========================================
  Files         147      147              
  Lines       30735    30753      +18     
==========================================
  Hits         7761     7761              
- Misses      22088    22106      +18     
  Partials      886      886              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Hueter57 Hueter57 requested a review from H1rono December 6, 2024 15:26
Copy link
Member

@H1rono H1rono left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

とりあえず

router/transaction.go Outdated Show resolved Hide resolved
service/webhook.go Outdated Show resolved Hide resolved
service/webhook.go Outdated Show resolved Hide resolved
@Hueter57 Hueter57 requested a review from H1rono December 6, 2024 15:56
Copy link
Member

@H1rono H1rono left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

service/webhook.go Outdated Show resolved Hide resolved
@Hueter57 Hueter57 requested a review from H1rono December 9, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants